Re: [BUG](-mm)pci_disable_device function clear bars_enabled element

Kenji Kaneshige
2006-06-02T03:00:45Z

Hi,

Sorry for replying late.

I understand that I had a woring assumption and I need to change my
patch. I'll post the fixed one as soon as possible.

As Rajesh pointed out, there are many drivers which initialize the
device with the wrong order. They should be fixed. I would like to
confirm the correct order to initialize the device again. Is the
following correct order?

(1) pci_request_regions()

(2) pci_enable_device()

(3) request_irq()

(4) free_irq()

(5) pci_disable_device()

(6) pci_release_regions()

Thanks,
Kenji Kaneshige

Rajesh Shah wrote:
> On Thu, Jun 01, 2006 at 11:15:59AM -0600, Grant Grundler wrote:
>
>>+ The device driver needs to call pci_request_region() to make sure
>>+no other device is already using the same resource. The driver is expected
>>+to determine MMIO and IO Port resource availability _before_ calling
>>+pci_enable_device(). Conversely, drivers should call pci_release_region()
>>+_after_ calling pci_disable_device(). The idea is to prevent two devices
>>+colliding on the same address range.
>>+
>
> A quick look in the drivers directory shows that _lots_ of drivers
> violate this rule. In fact, I suspect Kaneshige-san made the original
> incorrect assumption since there were so many drivers out there
> which do it in the wrong order.
>
> Rajesh
>