Re: [PATCH 3/4] Make Intel e1000 driver legacy I/O port free

Kenji Kaneshige
2006-06-08T17:04:04Z

Jeff Garzik wrote:
> Kenji Kaneshige wrote:
>
>>No, those tasks are done through pci_enable_device_bars() called from
>>pci_enable_device() actually. In addition, I made small changes to
>>pci_enable_device() and pci_enable_device_bars() in another patch ([PATCH 1/4]).
>>Now pci_enable_device_bars() just call pci_enable_device_bars() like below:
>>
>>int
>>pci_enable_device(struct pci_dev *dev)
>>{
>> int err = pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1);
>> if (err)
>> return err;
>> return 0;
>>}
>
>
> You'll likely break IDE with such a change, which I also NAK. You can't
> just blindly do everything that pci_enable_device() does in IDE, which
> was the entire reason why pci_enable_device_bars() was added by Alan in
> the first place.
>

Could you tell me what will be broken by my change? I only moved the
following two lines from pci_enable_device() to pci_enable_device_bars().

pci_fixup_device(pci_fixup_enable, dev);
dev->is_enabled = 1;

Thanks,
Kenji Kaneshige