Re: 2.6.17-rc6-mm1

Andi Kleen
2006-06-08T02:25:42Z

Andrew Morton <akpm@osdl.org> writes:

> On Thu, 8 Jun 2006 00:31:53 +0200
> "J.A. Magallón" <jamagallon@ono.com> wrote:
>
> > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x3c)
> > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x40)
> > WARNING: drivers/block/floppy.o - Section mismatch: reference to .init.text: from .smp_locks after '' (at offset 0x44)
>
> Yes, that's a false positive - doing locking from within an __init section.
> We need to shut that up somehow.

Are you sure it's false?

I don't see an explicit check in alternatives.c for the main kernel
vs init sections and with CPU hotplug the alternatives can be applied
arbitarily after the system has booted. So it would just stomp
over the init text pages which are used for something else now.

I guess to make it safe you would need to teach alternative.c to
ignore init sections.

-Andi