public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jay Lan <jlan@engr.sgi.com>
To: Shailabh Nagar <nagar@watson.ibm.com>
Cc: Balbir Singh <balbir@in.ibm.com>, Andrew Morton <akpm@osdl.org>,
	lkml <linux-kernel@vger.kernel.org>,
	csturtiv@sgi.com, jamal <hadi@cyberus.ca>
Subject: Re: taskstats interface for accounting
Date: Wed, 07 Jun 2006 16:45:20 -0700	[thread overview]
Message-ID: <44876510.1050808@engr.sgi.com> (raw)
In-Reply-To: <44864030.6010906@watson.ibm.com>

Shailabh Nagar wrote:
> Jay Lan wrote:
>
>> Hi Balbir and Shailabh,
>>
>> I finally have time to think about implementation details of CSA over
>> taskstats interface. I took another look at the taskstats interface
>> proposal and was a little bit nervous.
>>
>> Do you remember i suggested to use #ifdef to cut down traffic and i
>> was told a generic netlink header would serve the purpose?
>> What i see now at Documentation/accounting/taskstats.txt saying
>> NETLINK_GENERIC family is used for unicast query/reply mode. The
>> NETLINK_GENERIC family provides great flexsibility on what to
>> receive. However, CSA only uses the multicast mode to receive from
>> kernel
>> whenever tasks are existing. I guess i would need to read the netlink
>> documentation more carefully to see whether my understanding is
>> correct.
>
> I don't think there's a problem here. The netlink socket opened for
> listening to
> taskstat data sent on task exit can be done in multicast mode....the
> example code in the
> Documentation does that.
>
>>
>> Another thing i overlooked when i did the review was that taskstats
>> interface is designed to provide _BOTH_ per task _AND_ per thread
>> accounting data EVERY TIME a task exists. A thread is an aggregate
>> of (per-pid) tasks. Since this type of aggregation is not used in
>> CSA, half of data traffic would be useless. Can we add a way to
>> configure to not send per-thread data to the socket?
>
> I don't see why not. We could extend the command set to set tgid
> sending on/off.

This would be great!

But, we can have a number of applications listening on the socket. We
surely do not want applications to send conflicting commands to the kernel.
Maybe we can make it a /etc/sysconfig option.

Regards,
 - jay

>
> Regards,
> Shailabh
>
>> Regards,
>> jay
>
>


  reply	other threads:[~2006-06-07 23:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-07  2:01 taskstats interface for accounting Jay Lan
2006-06-07  2:55 ` Shailabh Nagar
2006-06-07 23:45   ` Jay Lan [this message]
2006-06-08 15:45     ` Shailabh Nagar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44876510.1050808@engr.sgi.com \
    --to=jlan@engr.sgi.com \
    --cc=akpm@osdl.org \
    --cc=balbir@in.ibm.com \
    --cc=csturtiv@sgi.com \
    --cc=hadi@cyberus.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nagar@watson.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox