From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751678AbdB0NIu (ORCPT ); Mon, 27 Feb 2017 08:08:50 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:52846 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751338AbdB0NH4 (ORCPT ); Mon, 27 Feb 2017 08:07:56 -0500 X-AuditID: b6c32a59-f79736d000001328-9c-58b421c11cda From: Bartlomiej Zolnierkiewicz To: Krzysztof Kozlowski Cc: Lee Jones , Chanwoo Choi , Liam Girdwood , Mark Brown , linux-kernel@vger.kernel.org Subject: Re: [RFT 0/4] mfd: regulator: max14577: Remove support for platform data Date: Mon, 27 Feb 2017 13:55:26 +0100 Message-id: <4488092.RcVZiftjQz@amdc3058> User-Agent: KMail/4.13.3 (Linux/3.13.0-96-generic; KDE/4.13.3; x86_64; ; ) In-reply-to: <20170217200200.4521-1-krzk@kernel.org> MIME-version: 1.0 Content-transfer-encoding: 7Bit Content-type: text/plain; charset=us-ascii X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42LZdlhTXfeg4pYIg3O32S2mPnzCZnH9y3NW i/PnN7Bb3P96lNHi25UOJovLu+awObB57Jx1l91j06pONo871/awefRtWcXo8XmTXABrFJdN SmpOZllqkb5dAlfGkY52loIbPBUbzixnbmD8zNnFyMkhIWAi8bzxJiuELSZx4d56ti5GLg4h gaWMEm+eXWMDSQgJtDNJ3D5WAtPwZMUdJoiiOYwSW5duZ4FwvjJKXOr6DDaKTcBKYmL7KkYQ W0RAU+L63++sIEXMApsYJT6/Ps8CkhAWCJZoWNsNZHNwsAioSlw7JAsS5gWqf376FjuILSrg JbFlXzsTiM0JtPnDtCnsEDWCEj8m3wMbwywgL7Fv/1RWCFtH4uyxdYwguyQElrFLbL/yC2y+ hICsxKYDzBAfuEgcWjKdEcIWlnh1fAs7hC0t8XfpLaj4dEaJ7b8lIOZsZpRYtXsCVJG1xOHj F6GW8Un0/n7CBDGfV6KjTQiixEPi/Oon0CB1lFh/aAErJIDaGSU2vd3INIFRfhaSH2Yh+WEW kh8WMDKvYhRLLSjOTU8tNi0w1StOzC0uzUvXS87P3cQITiVakTsYr8wMOsQowMGoxMObcXxz hBBrYllxZe4hRgkOZiUR3ucKWyKEeFMSK6tSi/Lji0pzUosPMUpzsCiJ80YZTIwQEkhPLEnN Tk0tSC2CyTJxcEo1MNZwf5Bqf3ImZVX8qhU8G3nOGZssvRe8bl9cTlqI0qMYO1sRW2mzPaf/ q/8WuHHtqsbln7kva8q2XH8ze89x+Rcbqrb97nDw7ovRmXRMPP2Bad2WJQIcYT//PJJYOd3A It5ne/Mr3v7JM55Uqr4W5n6dJj5nX0KITGftQ6t41qOOOfp3b096XazEUpyRaKjFXFScCADG +8oMIQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsVy+t9jQd0DilsiDDo/q1hMffiEzeL6l+es FufPb2C3uP/1KKPFtysdTBaXd81hc2Dz2DnrLrvHplWdbB53ru1h8+jbsorR4/MmuQDWKDeb jNTElNQihdS85PyUzLx0W6XQEDddCyWFvMTcVFulCF3fkCAlhbLEnFIgz8gADTg4B7gHK+nb JbhlHOloZym4wVOx4cxy5gbGz5xdjJwcEgImEk9W3GGCsMUkLtxbz9bFyMUhJDCLUeLTsUUs EM5XRon/TU3sIFVsAlYSE9tXMYLYIgKaEtf/fmcFKWIW2MQo8WrtTmaQhLBAsETD2m6gbg4O FgFViWuHZEHCvED1z0/fApsjKuAlsWVfO9hmTqArPkybwg6xrJNR4uObJ2wQDYISPybfYwGx mQXkJfbtn8oKYWtJrN95nGkCI9CdCGWzkJTNQlK2gJF5FaNEakFyQXFSeq5RXmq5XnFibnFp Xrpecn7uJkZwdD2T3sF4eJf7IUYBDkYlHl4Js80RQqyJZcWVuYcYJTiYlUR4nytsiRDiTUms rEotyo8vKs1JLT7EaAr04ERmKdHkfGDk55XEG5qYm5gbG1iYW1qaGCmJ8zbOfhYuJJCeWJKa nZpakFoE08fEwSnVwNgqoLr22p2Ti3z4j9ut1l6ayMqmlcwxhynR8fhRFeeo+AMh8w8/q0kO M80Luz3fcslqv6N6HcYXn/q4J2TnTt7/JspE/FL4U83gxx81Zky2LHo+nTewaUe857FbebtP LJ61zkrKm0nV3nFTSrKSyMZn99/dKLpx++d+u5Wrda6zCrjvPPUo0kqJpTgj0VCLuag4EQDP lPjdxAIAAA== X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170227125528epcas5p4bc01fa6573db7697891b3d13b2031205 X-Msg-Generator: CA X-Sender-IP: 203.254.230.27 X-Local-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRvsgrzshLHsoITsnpAbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Global-Sender: =?UTF-8?B?QmFydGxvbWllaiBab2xuaWVya2lld2ljehtTUlBPTC1LZXJu?= =?UTF-8?B?ZWwgKFRQKRtTYW1zdW5nIEVsZWN0cm9uaWNzG1NlbmlvciBTb2Z0d2FyZSBF?= =?UTF-8?B?bmdpbmVlcg==?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-HopCount: 7 X-CMS-RootMailID: 20170217200214epcas3p4d72abd10d1ce7dbbbcd626bcf452fa37 X-RootMTR: 20170217200214epcas3p4d72abd10d1ce7dbbbcd626bcf452fa37 References: <20170217200200.4521-1-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Friday, February 17, 2017 10:01:56 PM Krzysztof Kozlowski wrote: > Hi, > > Minor cleanup of max14577 family of drivers. The dependency inside: > 1. Patch #3 and #4 depends for safeness on #1 so no one would try to > run the driver on non-DT platform (such platform does not exist anyway...). > 2. Patch #4 depends on patch #3 (compile time dependency). > > Unfortunately I do not have the boards using these drivers, so testing > would be appreciated. Your patchset looks fine to me but I've noticed that maxim,max14577 bindings are not used currently in the mainline kernel. AFAIK MAX14577 support is needed only for Gear1 board which doesn't have DTS file in the upstream kernel (moreover Exynos4212 SoC support has been removed recently). It seems that MAX14577 support should also go away (unless there are some other boards using it that we support in the mainline kernel). Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics > Best regards, > Krzysztof > > Krzysztof Kozlowski (4): > mfd: max14577: Explicitly depend on OF > mfd: max14577: Export OF module alias information > regulator: max14577: Remove support for platform data > mfd: max14577: Remove platform data and instantiation from I2C > > drivers/mfd/Kconfig | 1 + > drivers/mfd/max14577.c | 23 +---------------------- > drivers/regulator/max14577-regulator.c | 15 +++------------ > include/linux/mfd/max14577.h | 20 -------------------- > 4 files changed, 5 insertions(+), 54 deletions(-)