From: Paul Fulghum <paulkf@microgate.com>
To: Andrew Morton <akpm@osdl.org>
Cc: jeff@garzik.org, linux-kernel@vger.kernel.org,
"Randy.Dunlap" <rdunlap@xenotime.net>
Subject: Re: [PATCH] fix generic HDLC synclink mismatch build error
Date: Thu, 08 Jun 2006 08:20:08 -0500 [thread overview]
Message-ID: <44882408.3060303@microgate.com> (raw)
In-Reply-To: <20060607182808.a230e5ee.akpm@osdl.org>
Andrew Morton wrote:
> Well your patch looked reasonable, except it muddies the CONFIG_foo
> namespace.
I had misinterpreted Jeff's post as saying defining
macros based on kernel configuration for conditional
compilation was not allowed.
With Andrew's technical explanation that altering
the CONFIG_X namespace in code is the problem,
the cleanest solution is to combine Randy's last patch
with fix-kbuild-dependencies-for-synclink-drivers.patch
I'll combine those two against 2.6.7-rc6-mm1
--
Paul Fulghum
Microgate Systems, Ltd.
prev parent reply other threads:[~2006-06-08 13:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 15:42 [PATCH] fix generic HDLC synclink mismatch build error Paul Fulghum
2006-06-07 21:31 ` Randy.Dunlap
2006-06-07 21:43 ` Paul Fulghum
2006-06-07 21:48 ` Randy.Dunlap
2006-06-07 22:00 ` Paul Fulghum
2006-06-09 15:47 ` Paul Fulghum
2006-06-09 16:00 ` Roman Zippel
2006-06-09 16:16 ` Paul Fulghum
2006-06-09 16:37 ` Roman Zippel
2006-06-09 16:44 ` Paul Fulghum
2006-06-07 22:58 ` Roman Zippel
2006-06-08 0:23 ` Paul Fulghum
2006-06-08 2:38 ` Randy.Dunlap
2006-06-07 23:02 ` Jeff Garzik
2006-06-08 0:20 ` Paul Fulghum
2006-06-08 0:59 ` Paul Fulghum
2006-06-08 1:28 ` Andrew Morton
2006-06-08 1:52 ` Paul Fulghum
2006-06-08 13:20 ` Paul Fulghum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44882408.3060303@microgate.com \
--to=paulkf@microgate.com \
--cc=akpm@osdl.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox