From: Jeff Garzik <jeff@garzik.org>
To: Kenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Cc: akpm@osdl.org, Greg KH <greg@kroah.com>,
Rajesh Shah <rajesh.shah@intel.com>,
Grant Grundler <grundler@parisc-linux.org>,
"bibo,mao" <bibo.mao@intel.com>,
linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz,
Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH 3/4] Make Intel e1000 driver legacy I/O port free
Date: Thu, 08 Jun 2006 10:46:48 -0400 [thread overview]
Message-ID: <44883858.3090708@garzik.org> (raw)
In-Reply-To: <44882787.20901@jp.fujitsu.com>
Kenji Kaneshige wrote:
> No, those tasks are done through pci_enable_device_bars() called from
> pci_enable_device() actually. In addition, I made small changes to
> pci_enable_device() and pci_enable_device_bars() in another patch ([PATCH 1/4]).
> Now pci_enable_device_bars() just call pci_enable_device_bars() like below:
>
> int
> pci_enable_device(struct pci_dev *dev)
> {
> int err = pci_enable_device_bars(dev, (1 << PCI_NUM_RESOURCES) - 1);
> if (err)
> return err;
> return 0;
> }
You'll likely break IDE with such a change, which I also NAK. You can't
just blindly do everything that pci_enable_device() does in IDE, which
was the entire reason why pci_enable_device_bars() was added by Alan in
the first place.
Jeff
next prev parent reply other threads:[~2006-06-08 14:46 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-01 7:05 [BUG](-mm)pci_disable_device function clear bars_enabled element bibo,mao
2006-06-01 9:46 ` Rajesh Shah
2006-06-01 17:15 ` Grant Grundler
2006-06-01 18:36 ` Rajesh Shah
2006-06-02 2:57 ` Kenji Kaneshige
2006-06-02 5:56 ` Grant Grundler
2006-06-02 7:31 ` Kenji Kaneshige
2006-06-03 23:21 ` Grant Grundler
2006-06-04 21:01 ` Greg KH
2006-06-05 12:40 ` [BUG][PATCH 2.6.17-rc5-mm3] bugfix: PCI legacy I/O port free driver Kenji Kaneshige
2006-06-06 7:58 ` Greg KH
2006-06-06 8:17 ` Kenji Kaneshige
2006-06-07 3:10 ` Kenji Kaneshige
2006-06-07 3:12 ` [PATCH 1/4] Changes to generic pci code Kenji Kaneshige
2006-06-07 3:13 ` [PATCH 2/4] Update Documentation/pci.txt Kenji Kaneshige
2006-06-07 3:14 ` [PATCH 3/4] Make Intel e1000 driver legacy I/O port free Kenji Kaneshige
2006-06-07 5:10 ` Auke Kok
2006-06-07 7:39 ` Kenji Kaneshige
2006-06-07 14:40 ` Auke Kok
2006-06-08 12:31 ` Jeff Garzik
2006-06-08 13:35 ` Kenji Kaneshige
2006-06-08 14:46 ` Jeff Garzik [this message]
2006-06-08 17:00 ` Kenji Kaneshige
2006-06-07 3:15 ` [PATCH 4/4] Make Emulex lpfc " Kenji Kaneshige
2006-06-07 8:24 ` Christoph Hellwig
2006-06-07 12:23 ` Kenji Kaneshige
2006-06-07 12:43 ` Christoph Hellwig
2006-06-07 13:11 ` Kenji Kaneshige
2006-06-07 13:40 ` Christoph Hellwig
2006-06-07 13:56 ` Kenji Kaneshige
2006-06-07 14:52 ` Christoph Hellwig
2006-06-07 17:26 ` Rajesh Shah
2006-06-02 4:42 ` [BUG](-mm)pci_disable_device function clear bars_enabled element Grant Grundler
2006-06-02 16:50 ` Rajesh Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44883858.3090708@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bibo.mao@intel.com \
--cc=greg@kroah.com \
--cc=grundler@parisc-linux.org \
--cc=kaneshige.kenji@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=rajesh.shah@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox