Re: [PATCH 4/4] Make Emulex lpfc driver legacy I/O port free

Christoph Hellwig
2006-06-07T14:52:25Z

On Wed, Jun 07, 2006 at 10:56:07PM +0900, Kenji Kaneshige wrote:
> Christoph Hellwig wrote:
> >On Wed, Jun 07, 2006 at 10:11:12PM +0900, Kenji Kaneshige wrote:
> >
> >>I mean the right order is
> >>
> >> (1) pci_request_regions()
> >> (2) pci_enable_device*()
> >
> >
> >no, pci_enable_device should be first.
> >
> >
>
> I had the same wrong assumption before. But to prevent two
> devices colliding on the same address range, pci_request_regions()
> should be called first. Please see the following discussions:

No. That's what the pci_driver matching is for. Without pci_enable_device
pci_request_regions could do the wrong thing when fixups aren't run.