Re: [PATCH 4/4] Make Emulex lpfc driver legacy I/O port free

Kenji Kaneshige
2006-06-07T13:14:35Z

Christoph Hellwig wrote:
> On Wed, Jun 07, 2006 at 09:23:19PM +0900, Kenji Kaneshige wrote:
>
>>No. Your idea is very similar to the idea of previous version of my patche
>>which had a bug. The problem is that it doesn't work if
>>pci_request_regions()
>>is called before pci_enable_device*() (This is the correct order, though so
>>many drivers breaks this rule).
>
>
> Doesn't matter. Drivers not using pci_enable_device_noioport should be
> unaffect. Any any driver you convert should be fixed to do thing in
> the right order.
>
>

I mean the right order is

(1) pci_request_regions()
(2) pci_enable_device*()

So there are no chance to set the flag for pci_request_regions() to
know which regions should be requested.

Thanks,
Kenji Kaneshige