From: "H. Peter Anvin" <hpa@c2micro.com>
To: Bjorn Helgaas <bjorn.helgaas@hp.com>
Cc: linux-kernel@vger.kernel.org, Andrew Morton <akpm@osdl.org>,
Greg KH <greg@kroah.com>,
mchan@broadcom.com
Subject: Re: tg3 broken on 2.6.17-rc5-mm3
Date: Thu, 08 Jun 2006 22:03:19 -0700 [thread overview]
Message-ID: <44890117.1000403@c2micro.com> (raw)
In-Reply-To: <200606082249.14475.bjorn.helgaas@hp.com>
Bjorn Helgaas wrote:
> On Wednesday 07 June 2006 17:11, Bjorn Helgaas wrote:
>> Something changed between 2.6.17-rc5-mm2 and -mm3 that broke tg3
>> on my HP DL360:
>
> and the specific change that broke it seems to be:
> gregkh-pci-pci-ignore-pre-set-64-bit-bars-on-32-bit-platforms.patch.
>
> pci_read: 0000:01:02.0 reg 0x10 len 4 val 0xf7ef0004
> pci_write: 0000:01:02.0 reg 0x10 len 4 val 0xffffffff
> pci_read: 0000:01:02.0 reg 0x10 len 4 val 0xffff0004
> pci_write: 0000:01:02.0 reg 0x10 len 4 val 0xf7ef0004
> pci_read: 0000:01:02.0 reg 0x14 len 4 val 0x0000
> pci_write: 0000:01:02.0 reg 0x14 len 4 val 0xffffffff
> pci_read: 0000:01:02.0 reg 0x14 len 4 val 0xffffffff
> pci_write: 0000:01:02.0 reg 0x14 len 4 val 0x0000
... this is a 64-bit BAR preset with a 16-bit mask, preset
to the valid 32-bit address 0x0000_0000_f7ef_0000.
> pci_write: 0000:01:02.0 reg 0x10 len 4 val 0x0004 <=== looks questionable
> pci_write: 0000:01:02.0 reg 0x14 len 4 val 0x0000
... here the algorithm thinks the addrss is above 4 GB and disables it.
It should re-enable it when the device is turned back on, though; if
it doesn't that's very strange.
Anyway, the error seems to be that the line:
+ } else if (l) {
... should be ...
+ } else if (lhi) {
... since l contains the lower half of the pre-set address at that
point, and lhi is the upper half.
-hpa
next prev parent reply other threads:[~2006-06-09 5:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-07 23:11 tg3 broken on 2.6.17-rc5-mm3 Bjorn Helgaas
2006-06-07 22:49 ` Michael Chan
2006-06-08 0:36 ` Andrew Morton
2006-06-08 8:40 ` Frederik Deweerdt
[not found] ` <200606082249.14475.bjorn.helgaas@hp.com>
2006-06-09 5:03 ` H. Peter Anvin [this message]
2006-06-09 16:05 ` Bjorn Helgaas
2006-06-09 18:28 ` [PATCH] fix to pci ignore pre-set 64-bit bars on 32-bit platforms H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44890117.1000403@c2micro.com \
--to=hpa@c2micro.com \
--cc=akpm@osdl.org \
--cc=bjorn.helgaas@hp.com \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mchan@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox