public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Suzuki <suzuki@in.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Fix Compilation error for UM Linux
Date: Fri, 09 Jun 2006 10:41:43 +0530	[thread overview]
Message-ID: <4489030F.4020004@in.ibm.com> (raw)
In-Reply-To: <20060608104655.70c6836f.akpm@osdl.org>

Andrew Morton wrote:
> On Thu, 08 Jun 2006 20:34:08 +0530
> Suzuki <suzuki@in.ibm.com> wrote:
> 
> 
>>Hi,
>>
>>This patch fixes the compilation error for UM Linux with linux-2.6.17-rc5.
>>
>>It complains of using (void *) in arithmetic.
> 
> 
> Really?  We often do arithmetic on void*.  Are you using gcc, with standard
> kbuild and standard compiler options?

Ah ! I was using g++ since the kernel had some C++ code in it. Sorry for 
the same.

> 
> 
>>Thanks.
>>
>>Suzuki K P
>>Linux Technology Center,
>>IBM Software Labs.
>>
>>
>>
>>* Fix the compilation error for um-linux.
>>
>>Signed Off by: Suzuki K P <suzuki@in.ibm.com>
> 
> 
> "Signed-off-by:", please.
Sorry ! Will take care of it from now onwards.


Thanks,

Suzuki
> 
> 
>>--- arch/um/include/mem.h       2006-05-25 01:45:04.000000000 -0700
>>+++ arch/um/include/mem.h~fix_compilation_error 2006-06-08 
>>07:46:21.000000000 -0700
>>@@ -22,7 +22,7 @@ static inline unsigned long to_phys(void
>>
>>  static inline void *to_virt(unsigned long phys)
>>  {
>>-       return((void *) uml_physmem + phys);
>>+       return (void *) (uml_physmem + phys);
>>  }
>>
>>  #endif

      parent reply	other threads:[~2006-06-09  5:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-08 15:04 Fix Compilation error for UM Linux Suzuki
2006-06-08 17:46 ` Andrew Morton
2006-06-09  0:22   ` Jeff Dike
2006-06-09  5:11   ` Suzuki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4489030F.4020004@in.ibm.com \
    --to=suzuki@in.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox