Re: Fix Compilation error for UM Linux

Andrew Morton
2006-06-08T17:47:01Z

On Thu, 08 Jun 2006 20:34:08 +0530
Suzuki <suzuki@in.ibm.com> wrote:

> Hi,
>
> This patch fixes the compilation error for UM Linux with linux-2.6.17-rc5.
>
> It complains of using (void *) in arithmetic.

Really? We often do arithmetic on void*. Are you using gcc, with standard
kbuild and standard compiler options?

> Thanks.
>
> Suzuki K P
> Linux Technology Center,
> IBM Software Labs.
>
>
>
> * Fix the compilation error for um-linux.
>
> Signed Off by: Suzuki K P <suzuki@in.ibm.com>

"Signed-off-by:", please.

> --- arch/um/include/mem.h 2006-05-25 01:45:04.000000000 -0700
> +++ arch/um/include/mem.h~fix_compilation_error 2006-06-08
> 07:46:21.000000000 -0700
> @@ -22,7 +22,7 @@ static inline unsigned long to_phys(void
>
> static inline void *to_virt(unsigned long phys)
> {
> - return((void *) uml_physmem + phys);
> + return (void *) (uml_physmem + phys);
> }
>
> #endif