Re: [PATCH] fix generic HDLC synclink mismatch build error

Randy.Dunlap
2006-06-08T02:35:47Z

On Wed, 07 Jun 2006 19:23:21 -0500 Paul Fulghum wrote:

> Roman Zippel wrote:
> > Hi,
> >
> > On Wed, 7 Jun 2006, Paul Fulghum wrote:
> >
> >
> >>-#ifdef CONFIG_HDLC_MODULE
> >>+#if defined(CONFIG_HDLC_MODULE) && defined(CONFIG_SYNCLINK_MODULE)
> >> #define CONFIG_HDLC 1
> >> #endif
> >
> >
> > Please don't define your own config symbols, just use Kconfig for this,
> > simply remove the prompts from your earlier patch and add the dependecies
> > as Randy suggested.
>
> Randy's patch defines config symbols, so I don't know what you are getting at.

Yes, but in the config language, not inside a driver source file.

---
~Randy