Re: [PATCH] fix generic HDLC synclink mismatch build error

Roman Zippel
2006-06-09T16:37:48Z

Hi,

On Fri, 9 Jun 2006, Paul Fulghum wrote:

> Roman Zippel wrote:
> > > +config SYNCLINK_HDLC
> > > + bool "Generic HDLC support for SyncLink driver"
> > > + depends on SYNCLINK
> > > + depends on HDLC=y || HDLC=SYNCLINK
> >
> >
> > If you replace now 'bool "..."' with 'def_bool y', it's enabled
> > automatically as soon as HDLC is enabled and the user doesn't has to confirm
> > it for every driver separately and it has the same effect as your #ifdef
> > hack.
>
> You need to explain this more.

Just try it. :)

> The only #ifdef in the patch is that which conditionally
> compiles the generic HDLC support based on the
> kernel configuration option. If I remove those, then
> the synclink would require generic HDLC, which
> is not what we want.

I meant the old #ifdef hack, which your patch removed.

bye, Roman