Re: [PATCH] fix generic HDLC synclink mismatch build error

Randy.Dunlap
2006-06-07T21:46:18Z

On Wed, 07 Jun 2006 16:43:43 -0500 Paul Fulghum wrote:

> Randy.Dunlap wrote:
> > See my new patch below. All done in Kconfig, no
> > source file changes needed. Highly preferable. :)
>
> The effect is the exact same as mine (if there is a mismatch
> then generic HDLC support for synclink is silently disabled),
> and your patch is against a patch that has already been dropped.
>
> The only difference is the granularity of enabling
> the HDLC option for individual synclink adapter types,
> which is not really an issue (as this is not in <= 2.6.16 anyways).
>
> I'd prefer to stick with my patch as it is simpler,
> and maintains compatibility with the way thing are done
> in <= 2.6.16 (customer documentation does not need updating).

Sure, that's fine, your call.

I just wanted you to see how this is handled in some other places
in the kernel tree.

---
~Randy