From: Hans Reiser <reiser@namesys.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: "Barry K. Nathan" <barryn@pobox.com>,
Valdis.Kletnieks@vt.edu, Andrew Morton <akpm@osdl.org>,
arjan@linux.intel.com, linux-kernel@vger.kernel.org,
reiserfs-dev@namesys.com
Subject: Re: 2.6.17-rc5-mm3: bad unlock ordering (reiser4?)
Date: Fri, 09 Jun 2006 14:36:24 -0700 [thread overview]
Message-ID: <4489E9D8.6090002@namesys.com> (raw)
In-Reply-To: <20060605065444.GA27445@elte.hu>
Ingo Molnar wrote:
> if (atomic_read(&node->d_count) != 0) {
> return 0;
> }
>
>why the braces, when on the next line it's not done:
>
> if (blocknr_is_fake(jnode_get_block(node)))
> return 0;
>
>it looks quite inconsistent.
>
I have a (roughly adhered to) rule that I don't hassle programmers much
about the style of any code that I can easily read. I truly do not care
where the braces are, I care if the comments and variable names are well
done. So that is why, and yes, I know I am an unusual manager on this
point.
prev parent reply other threads:[~2006-06-09 21:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-04 12:04 2.6.17-rc5-mm3: bad unlock ordering (reiser4?) Barry K. Nathan
2006-06-04 14:00 ` Barry K. Nathan
2006-06-04 20:33 ` Andrew Morton
2006-06-04 20:56 ` Valdis.Kletnieks
2006-06-04 21:34 ` Ingo Molnar
2006-06-04 22:03 ` Barry K. Nathan
2006-06-05 2:46 ` Hans Reiser
2006-06-05 6:54 ` Ingo Molnar
2006-06-05 7:37 ` Ingo Molnar
2006-06-05 11:22 ` Alexander Zarochentsev
2006-06-05 12:50 ` Ingo Molnar
2006-06-05 23:56 ` Hans Reiser
2006-06-05 7:58 ` Barry K. Nathan
2006-06-05 8:12 ` Ingo Molnar
2006-06-05 9:00 ` Barry K. Nathan
2006-06-09 21:39 ` Hans Reiser
2006-06-09 21:36 ` Hans Reiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4489E9D8.6090002@namesys.com \
--to=reiser@namesys.com \
--cc=Valdis.Kletnieks@vt.edu \
--cc=akpm@osdl.org \
--cc=arjan@linux.intel.com \
--cc=barryn@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox