From: Jeff Garzik <jeff@garzik.org>
To: HighPoint Linux Team <linux@highpoint-tech.com>
Cc: James.Bottomley@SteelEye.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, akpm@osdl.org
Subject: Re: [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver
Date: Sun, 11 Jun 2006 09:14:26 -0400 [thread overview]
Message-ID: <448C1732.3060809@garzik.org> (raw)
In-Reply-To: <200606111706.52930.linux@highpoint-tech.com>
HighPoint Linux Team wrote:
> --- a/drivers/scsi/hptiop.c
> +++ b/drivers/scsi/hptiop.c
> @@ -504,18 +504,10 @@ static int hptiop_queuecommand(struct sc
> BUG_ON(!done);
> scp->scsi_done = done;
>
> - /*
> - * hptiop_shutdown will flash controller cache.
> - */
> - if (scp->cmnd[0] == SYNCHRONIZE_CACHE) {
> - scp->result = DID_OK<<16;
> - goto cmd_done;
> - }
> -
> _req = get_req(hba);
> if (_req == NULL) {
> dprintk("hptiop_queuecmd : no free req\n");
> - scp->result = DID_BUS_BUSY << 16;
> + scp->result = SCSI_MLQUEUE_HOST_BUSY;
> goto cmd_done;
> }
Close. For the last bit of code quoted above, you should return
SCSI_MLQUEUE_HOST_BUSY as your ->queuecommand() return code, rather than
setting scp->result and calling the done() hook.
Jeff
next prev parent reply other threads:[~2006-06-11 13:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-11 9:07 [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver HighPoint Linux Team
2006-06-11 11:18 ` HighPoint Linux Team
2006-06-11 15:00 ` James Bottomley
2006-06-12 4:03 ` HighPoint Linux Team
2006-06-11 13:14 ` Jeff Garzik [this message]
2006-06-14 8:50 ` HighPoint Linux Team
2006-07-24 7:48 ` [PATCH] hptiop: wrong register used in hptiop_reset_hba() HighPoint Linux Team
[not found] <200605101704.27491.linux@highpoint-tech.com>
[not found] ` <200605121107.48597.linux@highpoint-tech.com>
2006-05-16 6:38 ` [PATCH] hptiop: HighPoint RocketRAID 3xxx controller driver HighPoint Linux Team
2006-06-10 15:36 ` James Bottomley
2006-06-10 16:47 ` Andrew Morton
2006-06-10 18:11 ` James Bottomley
[not found] <200605122209.k4CM95oW014664@mail.hypersurf.com>
2006-05-15 6:22 ` HighPoint Linux Team
2006-05-15 6:56 ` Arjan van de Ven
2006-05-15 7:25 ` Jeff Garzik
2006-05-15 14:59 ` Arjan van de Ven
-- strict thread matches above, loose matches on Subject: below --
2006-05-09 22:02 Allen
2006-05-10 8:25 ` Christoph Hellwig
2006-05-10 10:47 ` Alan Cox
2006-05-12 20:32 ` Arjan van de Ven
2006-05-09 21:28 Allen
2006-05-09 21:59 ` Alexey Dobriyan
2006-05-09 22:34 ` Alexey Dobriyan
2006-05-09 22:19 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448C1732.3060809@garzik.org \
--to=jeff@garzik.org \
--cc=James.Bottomley@SteelEye.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@highpoint-tech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox