From: Paul Fulghum <paulkf@microgate.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Chuck Ebbert <76306.1226@compuserve.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.16.18 kernel freezes while pppd is exiting
Date: Mon, 12 Jun 2006 11:11:27 -0500 [thread overview]
Message-ID: <448D922F.80801@microgate.com> (raw)
In-Reply-To: <1150127588.25462.7.camel@localhost.localdomain>
Alan Cox wrote:
>> spin_unlock_irqrestore(&tty->buf.lock, flags);
>>+ clear_bit(TTY_FLUSHING, &tty->flags);
>
>
> Shouldn't those two be reversed if you want to go with this path.
I don't see that is necessary.
> How is this occuring anyway the flush_to_ldisc path should never re-enter.
If a driver has low_latency set, flush_to_ldisc
can be called from both scheduled work (due to
hitting TTY_DONT_FLIP) and directly from an ISR.
On an SMP system, they can run in parallel.
I don't know for sure that is the path being hit,
it could be some other odd combination.
But there is no inherent serialization
of flush_to_ldisc.
--
Paul Fulghum
Microgate Systems, Ltd.
next prev parent reply other threads:[~2006-06-12 16:11 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 23:07 2.6.16.18 kernel freezes while pppd is exiting Chuck Ebbert
2006-06-09 13:35 ` Paul Fulghum
2006-06-12 15:07 ` Paul Fulghum
2006-06-12 15:53 ` Alan Cox
2006-06-12 16:11 ` Paul Fulghum [this message]
2006-06-12 16:36 ` Alan Cox
2006-06-12 16:25 ` Paul Fulghum
-- strict thread matches above, loose matches on Subject: below --
2006-06-12 16:36 Chuck Ebbert
2006-06-12 18:06 ` Paul Fulghum
2006-06-12 18:11 ` Paul Fulghum
2006-06-08 18:09 Chuck Ebbert
2006-06-08 20:08 ` Paul Fulghum
2006-06-08 21:17 ` Paul Fulghum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=448D922F.80801@microgate.com \
--to=paulkf@microgate.com \
--cc=76306.1226@compuserve.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox