public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andy Whitcroft <apw@shadowen.org>
To: Franck <vagabon.xyz@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [SPARSEMEM] confusing uses of SPARSEM_EXTREME (try #2)
Date: Mon, 12 Jun 2006 17:25:27 +0100	[thread overview]
Message-ID: <448D9577.3040903@shadowen.org> (raw)
In-Reply-To: <448D1117.8010407@innova-card.com>

Franck Bui-Huu wrote:
> Is it me or the use of CONFIG_SPARSEMEM_EXTREME is really confusing in
> mm/sparce.c ? Shouldn't we use CONFIG_SPARSEMEM_STATIC instead like
> the following patch suggests ?
> 
> -- >8 --
> Subject: [PATCH] Remove confusing uses of SPARSEMEM_EXTREME
> 
> CONFIG_SPARSEMEM_EXTREME is used in sparce.c whereas
> CONFIG_SPARSEMEM_STATIC seems to be more appropriate.
> 
> Signed-off-by: Franck Bui-Huu <vagabon.xyz@gmail.com> 

In my mind the positive option is selecting for code supporting EXTREME
so it seems to make sense to use that option.  Perhaps the confusion
comes from a lack of comments there to say that the else case is STATIC.

-apw

  parent reply	other threads:[~2006-06-12 16:25 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-12  7:00 [SPARSEMEM] confusing uses of SPARSEM_EXTREME (try #2) Franck Bui-Huu
2006-06-12 16:10 ` Dave Hansen
2006-06-13  8:51   ` Franck Bui-Huu
2006-06-12 16:25 ` Andy Whitcroft [this message]
2006-06-12 17:21   ` Franck Bui-Huu
2006-06-12 17:32     ` Andy Whitcroft
2006-06-13  8:34       ` Franck Bui-Huu
2006-06-13 10:05         ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448D9577.3040903@shadowen.org \
    --to=apw@shadowen.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vagabon.xyz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox