Re: [PATCH] clean tty fields on failed device open

Luiz Fernando N. Capitulino
2006-06-14T13:49:23Z

On Wed, 14 Jun 2006 13:52:30 +0200
Frank Gevaerts <frank.gevaerts@fks.be> wrote:

| On Tue, Jun 13, 2006 at 02:45:12PM -0300, Luiz Fernando N. Capitulino wrote:
| > Could you redo and submit please?
|
| OK. Here it is:
|
| Fixes a BUG on disconnect. gregkh-usb-usb-rmmod-pl2303-after-28.patch (from -mm trees)
| is also needed to fix all problems.

Hmm, I'd prefer something like this:

"""
If either the driver's open() method or try_module_get() fails, we need to
set 'tty->driver_data' and 'port->tty' to NULL in serial_open(), otherwise
we'll get an OOPS in usb_device_disconnect() when the device is disconnected.
"""

--
Luiz Fernando N. Capitulino