public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Mikulas Patocka <mpatocka@redhat.com>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-kernel@vger.kernel.org, Ard Biesheuvel <ardb@kernel.org>,
	 Sami Tolvanen <samitolvanen@google.com>,
	 Bart Van Assche <bvanassche@acm.org>,
	dm-devel@lists.linux.dev,  Alasdair Kergon <agk@redhat.com>,
	Mike Snitzer <snitzer@kernel.org>
Subject: Re: [PATCH 0/7] dm-verity cleanups and optimizations
Date: Thu, 4 Jul 2024 17:05:26 +0200 (CEST)	[thread overview]
Message-ID: <448e290-2c88-72ae-eaa9-c5d4b9388a42@redhat.com> (raw)
In-Reply-To: <20240703191546.GA1756@quark.localdomain>



On Wed, 3 Jul 2024, Eric Biggers wrote:

> On Mon, Jul 01, 2024 at 11:48:28PM -0700, Eric Biggers wrote:
> > This series contains some cleanups and optimizations for dm-verity that
> > I've split out from my multibuffer hashing series
> > https://lore.kernel.org/linux-crypto/20240621165922.77672-1-ebiggers@kernel.org/.
> > 
> > This series does not depend on any crypto API changes, so it can be
> > applied right away.
> > 
> > Eric Biggers (7):
> >   dm-verity: move hash algorithm setup into its own function
> >   dm-verity: move data hash mismatch handling into its own function
> >   dm-verity: make real_digest and want_digest fixed-length
> >   dm-verity: provide dma_alignment limit in io_hints
> >   dm-verity: always "map" the data blocks
> >   dm-verity: make verity_hash() take dm_verity_io instead of
> >     ahash_request
> >   dm-verity: hash blocks with shash import+finup when possible
> > 
> >  drivers/md/dm-verity-fec.c    |  32 +--
> >  drivers/md/dm-verity-fec.h    |   6 +-
> >  drivers/md/dm-verity-target.c | 461 ++++++++++++++++------------------
> >  drivers/md/dm-verity.h        |  39 ++-
> >  4 files changed, 242 insertions(+), 296 deletions(-)
> 
> Thanks for applying this, Mikulas!
> 
> I sent out a new version of "dm-verity: provide dma_alignment limit in io_hints"
> to address Christoph's comment.
> 
> Also, I noticed that when you applied the patches, patch 2 somehow ended up with
> the same commit message as patch 1.  Can you fix that?  Thanks!
> 
> - Eric

Hi

It should be fixed now.

Mikulas


      reply	other threads:[~2024-07-04 15:05 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-02  6:48 [PATCH 0/7] dm-verity cleanups and optimizations Eric Biggers
2024-07-02  6:48 ` [PATCH 1/7] dm-verity: move hash algorithm setup into its own function Eric Biggers
2024-07-02  6:48 ` [PATCH 2/7] dm-verity: move data hash mismatch handling " Eric Biggers
2024-07-02  6:48 ` [PATCH 3/7] dm-verity: make real_digest and want_digest fixed-length Eric Biggers
2024-07-02  6:48 ` [PATCH 4/7] dm-verity: provide dma_alignment limit in io_hints Eric Biggers
2024-07-02  7:16   ` Christoph Hellwig
2024-07-02  6:48 ` [PATCH 5/7] dm-verity: always "map" the data blocks Eric Biggers
2024-07-02  6:48 ` [PATCH 6/7] dm-verity: make verity_hash() take dm_verity_io instead of ahash_request Eric Biggers
2024-07-02  6:48 ` [PATCH 7/7] dm-verity: hash blocks with shash import+finup when possible Eric Biggers
2024-07-02  7:41   ` Ard Biesheuvel
2024-07-02 17:16     ` Eric Biggers
2024-07-03 13:17       ` Ard Biesheuvel
2024-07-03 19:15 ` [PATCH 0/7] dm-verity cleanups and optimizations Eric Biggers
2024-07-04 15:05   ` Mikulas Patocka [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=448e290-2c88-72ae-eaa9-c5d4b9388a42@redhat.com \
    --to=mpatocka@redhat.com \
    --cc=agk@redhat.com \
    --cc=ardb@kernel.org \
    --cc=bvanassche@acm.org \
    --cc=dm-devel@lists.linux.dev \
    --cc=ebiggers@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=samitolvanen@google.com \
    --cc=snitzer@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox