Re: [PATCH v7 4/4] drm/mediatek: Add DSI support for mt8188 vdosys0

Jason-JH Lin (林睿祥)
2023-07-31T16:09:11Z

Hi Angelo,

Thanks for the reviews.

On Fri, 2023-07-28 at 10:14 +0200, AngeloGioacchino Del Regno wrote:
> Il 27/07/23 18:41, Jason-JH.Lin ha scritto:
> > Add DSI as main display output for mt8188 vdosys0.
> >
>
> I would split this commit in two:
>
> 1. drm/mediatek: dsi: Support dynamic connector selection
> 2. drm/mediatek: Support DSI on MT8188 VDOSYS0
>
OK, I'll separate this commit like this.

Regards,
Jason-JH.Lin

> Where the first one sets up the mtk_dsi driver for .encoder_index(),
> and
> where the second one is a one-liner simply adding `{0,
> DDP_COMPONENT_DSI0},`
> to the MT8188 main routes array.
>
> The reason is that if you split it like that, whoever reads the
> commit history
> will immediately understand how to add dynamic connector selection to
> a MTK DRM
> driver, and how to perform the SoC-specific connection....
>
> Please!
>
> Thanks,
> Angelo
>