* NI5010 network driver -- MAINTAINERS entry
@ 2006-06-07 14:22 Pavel Machek
2006-06-07 15:00 ` Andreas Mohr
2006-06-13 19:06 ` [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry) Andreas Mohr
0 siblings, 2 replies; 6+ messages in thread
From: Pavel Machek @ 2006-06-07 14:22 UTC (permalink / raw)
To: jvbest, 100.30936, kernel list
...is quite inconsistent with rest of file:
NI5010 NETWORK DRIVER
P: Jan-Pascal van Best and Andreas Mohr
M: Jan-Pascal van Best <jvbest@qv3pluto.leidenuniv.nl>
M: Andreas Mohr <100.30936@germany.net>
L: netdev@vger.kernel.org
S: Maintained
probably should be
NI5010 NETWORK DRIVER
P: Jan-Pascal van Best
M: jvbest@qv3pluto.leidenuniv.nl
P: Andreas Mohr
M: 100.30936@germany.net
L: netdev@vger.kernel.org
S: Maintained
...yes, "new" mail address format makes sense, but I guess whole file
should be converted.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: NI5010 network driver -- MAINTAINERS entry
2006-06-07 14:22 NI5010 network driver -- MAINTAINERS entry Pavel Machek
@ 2006-06-07 15:00 ` Andreas Mohr
2006-06-13 19:06 ` [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry) Andreas Mohr
1 sibling, 0 replies; 6+ messages in thread
From: Andreas Mohr @ 2006-06-07 15:00 UTC (permalink / raw)
To: Pavel Machek; +Cc: jvbest, kernel list
Hi,
On Wed, Jun 07, 2006 at 04:22:14PM +0200, Pavel Machek wrote:
>
> ...is quite inconsistent with rest of file:
>
> NI5010 NETWORK DRIVER
> P: Jan-Pascal van Best and Andreas Mohr
> M: Jan-Pascal van Best <jvbest@qv3pluto.leidenuniv.nl>
> M: Andreas Mohr <100.30936@germany.net>
> L: netdev@vger.kernel.org
> S: Maintained
>
> probably should be
>
> NI5010 NETWORK DRIVER
> P: Jan-Pascal van Best
> M: jvbest@qv3pluto.leidenuniv.nl
> P: Andreas Mohr
> M: 100.30936@germany.net
Err, not quite ;)
> L: netdev@vger.kernel.org
> S: Maintained
>
> ...yes, "new" mail address format makes sense, but I guess whole file
> should be converted.
Right, I've been looking at this entry some time ago and thought that I
should send an update patch, but haven't gotten around to doing that yet.
Problem is that I'm not actively using this (admittedly historic) card
any more, so bug reports about this driver would probably have to be fixed
by the reporter or alternatively get delayed some time (I'm willing to
look into any reports, so status "Maintained" would still be sort of valid,
I think).
My currently "best" mail address is andi@lisas.de, not sure about
the validity of Jan-Pascal van Best's address, though.
Should I send an update patch (to -mm tree?), or do you want to do it?
Andreas Mohr
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry)
2006-06-07 14:22 NI5010 network driver -- MAINTAINERS entry Pavel Machek
2006-06-07 15:00 ` Andreas Mohr
@ 2006-06-13 19:06 ` Andreas Mohr
2006-06-13 20:27 ` Horst von Brand
1 sibling, 1 reply; 6+ messages in thread
From: Andreas Mohr @ 2006-06-13 19:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: Pavel Machek, janpascal, kernel list
Hi,
On Wed, Jun 07, 2006 at 04:22:14PM +0200, Pavel Machek wrote:
>
> ...is quite inconsistent with rest of file:
>
> NI5010 NETWORK DRIVER
> P: Jan-Pascal van Best and Andreas Mohr
> M: Jan-Pascal van Best <jvbest@qv3pluto.leidenuniv.nl>
> M: Andreas Mohr <100.30936@germany.net>
> L: netdev@vger.kernel.org
> S: Maintained
Right, fixed.
- updated MAINTAINERS entry to new format
- updated Jan-Pascal's (ACKed) and my email address
- driver cleanup/modernization (runtime-, not hardware-tested)
Signed-off-by: Andreas Mohr <andi@lisas.de>
diff -urN linux-2.6.17-rc6-mm2.orig/drivers/net/ni5010.c linux-2.6.17-rc6-mm2.my/drivers/net/ni5010.c
--- linux-2.6.17-rc6-mm2.orig/drivers/net/ni5010.c 2006-06-08 10:38:07.000000000 +0200
+++ linux-2.6.17-rc6-mm2.my/drivers/net/ni5010.c 2006-06-13 19:32:03.000000000 +0200
@@ -1,17 +1,12 @@
/* ni5010.c: A network driver for the MiCom-Interlan NI5010 ethercard.
*
- * Copyright 1996,1997 Jan-Pascal van Best and Andreas Mohr.
+ * Copyright 1996,1997,2006 Jan-Pascal van Best and Andreas Mohr.
*
* This software may be used and distributed according to the terms
* of the GNU General Public License, incorporated herein by reference.
*
* The authors may be reached as:
- * jvbest@wi.leidenuniv.nl a.mohr@mailto.de
- * or by snail mail as
- * Jan-Pascal van Best Andreas Mohr
- * Klikspaanweg 58-4 Stauferstr. 6
- * 2324 LZ Leiden D-71272 Renningen
- * The Netherlands Germany
+ * janpascal@vanbest.org andi@lisas.de
*
* Sources:
* Donald Becker's "skeleton.c"
@@ -27,8 +22,9 @@
* 970503 v0.93: Fixed auto-irq failure on warm reboot (JB)
* 970623 v1.00: First kernel version (AM)
* 970814 v1.01: Added detection of onboard receive buffer size (AM)
+ * 060611 v1.02: slight cleanup: email addresses, driver modernization.
* Bugs:
- * - None known...
+ * - not SMP-safe (no locking of I/O accesses)
* - Note that you have to patch ifconfig for the new /proc/net/dev
* format. It gives incorrect stats otherwise.
*
@@ -39,7 +35,7 @@
* Complete merge with Andreas' driver
* Implement ring buffers (Is this useful? You can't squeeze
* too many packet in a 2k buffer!)
- * Implement DMA (Again, is this useful? Some docs says DMA is
+ * Implement DMA (Again, is this useful? Some docs say DMA is
* slower than programmed I/O)
*
* Compile with:
@@ -47,7 +43,7 @@
* -DMODULE -c ni5010.c
*
* Insert with e.g.:
- * insmod ni5010.o io=0x300 irq=5
+ * insmod ni5010.o io=0x300 irq=5
*/
#include <linux/module.h>
@@ -69,15 +65,15 @@
#include "ni5010.h"
-static const char *boardname = "NI5010";
-static char *version =
- "ni5010.c: v1.00 06/23/97 Jan-Pascal van Best and Andreas Mohr\n";
+static const char boardname[] = "NI5010";
+static char version[] __initdata =
+ "ni5010.c: v1.02 20060611 Jan-Pascal van Best and Andreas Mohr\n";
/* bufsize_rcv == 0 means autoprobing */
static unsigned int bufsize_rcv;
-#define jumpered_interrupts /* IRQ line jumpered on board */
-#undef jumpered_dma /* No DMA used */
+#define JUMPERED_INTERRUPTS /* IRQ line jumpered on board */
+#undef JUMPERED_DMA /* No DMA used */
#undef FULL_IODETECT /* Only detect in portlist */
#ifndef FULL_IODETECT
@@ -121,7 +117,7 @@
static int io;
static int irq;
-struct net_device * __init ni5010_probe(int unit)
+static struct net_device * __init ni5010_probe(int unit)
{
struct net_device *dev = alloc_etherdev(sizeof(struct ni5010_local));
int *port;
@@ -281,7 +277,7 @@
PRINTK2((KERN_DEBUG "%s: I/O #4 passed!\n", dev->name));
-#ifdef jumpered_interrupts
+#ifdef JUMPERED_INTERRUPTS
if (dev->irq == 0xff)
;
else if (dev->irq < 2) {
@@ -305,7 +301,7 @@
} else if (dev->irq == 2) {
dev->irq = 9;
}
-#endif /* jumpered_irq */
+#endif /* JUMPERED_INTERRUPTS */
PRINTK2((KERN_DEBUG "%s: I/O #9 passed!\n", dev->name));
/* DMA is not supported (yet?), so no use detecting it */
@@ -334,7 +330,7 @@
outw(0, IE_GP); /* Point GP at start of packet */
outb(0, IE_RBUF); /* set buffer byte 0 to 0 again */
}
- printk("// bufsize rcv/xmt=%d/%d\n", bufsize_rcv, NI5010_BUFSIZE);
+ printk("-> bufsize rcv/xmt=%d/%d\n", bufsize_rcv, NI5010_BUFSIZE);
memset(dev->priv, 0, sizeof(struct ni5010_local));
dev->open = ni5010_open;
@@ -354,11 +350,9 @@
outb(0xff, EDLC_XCLR); /* Kill all pending xmt interrupts */
printk(KERN_INFO "%s: NI5010 found at 0x%x, using IRQ %d", dev->name, ioaddr, dev->irq);
- if (dev->dma) printk(" & DMA %d", dev->dma);
+ if (dev->dma)
+ printk(" & DMA %d", dev->dma);
printk(".\n");
-
- printk(KERN_INFO "Join the NI5010 driver development team!\n");
- printk(KERN_INFO "Mail to a.mohr@mailto.de or jvbest@wi.leidenuniv.nl\n");
return 0;
out:
release_region(dev->base_addr, NI5010_IO_EXTENT);
@@ -371,7 +365,7 @@
*
* This routine should set everything up anew at each open, even
* registers that "should" only need to be set once at boot, so that
- * there is non-reboot way to recover if something goes wrong.
+ * there is a non-reboot way to recover if something goes wrong.
*/
static int ni5010_open(struct net_device *dev)
@@ -390,13 +384,13 @@
* Always allocate the DMA channel after the IRQ,
* and clean up on failure.
*/
-#ifdef jumpered_dma
+#ifdef JUMPERED_DMA
if (request_dma(dev->dma, cardname)) {
printk(KERN_WARNING "%s: Cannot get dma %#2x\n", dev->name, dev->dma);
free_irq(dev->irq, NULL);
return -EAGAIN;
}
-#endif /* jumpered_dma */
+#endif /* JUMPERED_DMA */
PRINTK3((KERN_DEBUG "%s: passed open() #2\n", dev->name));
/* Reset the hardware here. Don't forget to set the station address. */
@@ -633,7 +627,7 @@
int ioaddr = dev->base_addr;
PRINTK2((KERN_DEBUG "%s: entering ni5010_close\n", dev->name));
-#ifdef jumpered_interrupts
+#ifdef JUMPERED_INTERRUPTS
free_irq(dev->irq, NULL);
#endif
/* Put card in held-RESET state */
@@ -771,7 +765,7 @@
MODULE_PARM_DESC(io, "ni5010 I/O base address");
MODULE_PARM_DESC(irq, "ni5010 IRQ number");
-int init_module(void)
+static int __init ni5010_init_module(void)
{
PRINTK2((KERN_DEBUG "%s: entering init_module\n", boardname));
/*
@@ -792,13 +786,15 @@
return 0;
}
-void cleanup_module(void)
+static void __exit ni5010_cleanup_module(void)
{
PRINTK2((KERN_DEBUG "%s: entering cleanup_module\n", boardname));
unregister_netdev(dev_ni5010);
release_region(dev_ni5010->base_addr, NI5010_IO_EXTENT);
free_netdev(dev_ni5010);
}
+module_init(ni5010_init_module);
+module_exit(ni5010_cleanup_module);
#endif /* MODULE */
MODULE_LICENSE("GPL");
diff -urN linux-2.6.17-rc6-mm2.orig/MAINTAINERS linux-2.6.17-rc6-mm2.my/MAINTAINERS
--- linux-2.6.17-rc6-mm2.orig/MAINTAINERS 2006-06-13 19:28:17.000000000 +0200
+++ linux-2.6.17-rc6-mm2.my/MAINTAINERS 2006-06-13 19:32:03.000000000 +0200
@@ -2072,9 +2072,10 @@
S: Maintained
NI5010 NETWORK DRIVER
-P: Jan-Pascal van Best and Andreas Mohr
-M: Jan-Pascal van Best <jvbest@qv3pluto.leidenuniv.nl>
-M: Andreas Mohr <100.30936@germany.net>
+P: Jan-Pascal van Best
+M: janpascal@vanbest.org
+P: Andreas Mohr
+M: andi@lisas.de
L: netdev@vger.kernel.org
S: Maintained
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry)
2006-06-13 19:06 ` [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry) Andreas Mohr
@ 2006-06-13 20:27 ` Horst von Brand
2006-06-14 19:28 ` Andreas Mohr
0 siblings, 1 reply; 6+ messages in thread
From: Horst von Brand @ 2006-06-13 20:27 UTC (permalink / raw)
To: Andreas Mohr; +Cc: Andrew Morton, Pavel Machek, janpascal, kernel list
Andreas Mohr <andi@rhlx01.fht-esslingen.de> wrote:
[...]
> @@ -47,7 +43,7 @@
> * -DMODULE -c ni5010.c
> *
> * Insert with e.g.:
> - * insmod ni5010.o io=0x300 irq=5
> + * insmod ni5010.o io=0x300 irq=5
> */
Should now be .ko ;-)
--
Dr. Horst H. von Brand User #22616 counter.li.org
Departamento de Informatica Fono: +56 32 654431
Universidad Tecnica Federico Santa Maria +56 32 654239
Casilla 110-V, Valparaiso, Chile Fax: +56 32 797513
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry)
2006-06-13 20:27 ` Horst von Brand
@ 2006-06-14 19:28 ` Andreas Mohr
2006-06-14 20:57 ` Jan-Pascal van Best
0 siblings, 1 reply; 6+ messages in thread
From: Andreas Mohr @ 2006-06-14 19:28 UTC (permalink / raw)
To: Horst von Brand; +Cc: Andrew Morton, Pavel Machek, janpascal, kernel list
Hi,
On Tue, Jun 13, 2006 at 04:27:06PM -0400, Horst von Brand wrote:
> Andreas Mohr <andi@rhlx01.fht-esslingen.de> wrote:
>
> [...]
>
> > @@ -47,7 +43,7 @@
> > * -DMODULE -c ni5010.c
> > *
> > * Insert with e.g.:
> > - * insmod ni5010.o io=0x300 irq=5
> > + * insmod ni5010.o io=0x300 irq=5
> > */
>
> Should now be .ko ;-)
Aaaargh... ;)
Complete waste of time... but I redid it anyway.
Signed-off-by: Andreas Mohr <andi@lisas.de>
diff -urN linux-2.6.17-rc6-mm2.orig/drivers/net/ni5010.c linux-2.6.17-rc6-mm2.my/drivers/net/ni5010.c
--- linux-2.6.17-rc6-mm2.orig/drivers/net/ni5010.c 2006-06-08 10:38:07.000000000 +0200
+++ linux-2.6.17-rc6-mm2.my/drivers/net/ni5010.c 2006-06-14 20:31:46.000000000 +0200
@@ -1,17 +1,12 @@
/* ni5010.c: A network driver for the MiCom-Interlan NI5010 ethercard.
*
- * Copyright 1996,1997 Jan-Pascal van Best and Andreas Mohr.
+ * Copyright 1996,1997,2006 Jan-Pascal van Best and Andreas Mohr.
*
* This software may be used and distributed according to the terms
* of the GNU General Public License, incorporated herein by reference.
*
* The authors may be reached as:
- * jvbest@wi.leidenuniv.nl a.mohr@mailto.de
- * or by snail mail as
- * Jan-Pascal van Best Andreas Mohr
- * Klikspaanweg 58-4 Stauferstr. 6
- * 2324 LZ Leiden D-71272 Renningen
- * The Netherlands Germany
+ * janpascal@vanbest.org andi@lisas.de
*
* Sources:
* Donald Becker's "skeleton.c"
@@ -27,8 +22,9 @@
* 970503 v0.93: Fixed auto-irq failure on warm reboot (JB)
* 970623 v1.00: First kernel version (AM)
* 970814 v1.01: Added detection of onboard receive buffer size (AM)
+ * 060611 v1.02: slight cleanup: email addresses, driver modernization.
* Bugs:
- * - None known...
+ * - not SMP-safe (no locking of I/O accesses)
* - Note that you have to patch ifconfig for the new /proc/net/dev
* format. It gives incorrect stats otherwise.
*
@@ -39,7 +35,7 @@
* Complete merge with Andreas' driver
* Implement ring buffers (Is this useful? You can't squeeze
* too many packet in a 2k buffer!)
- * Implement DMA (Again, is this useful? Some docs says DMA is
+ * Implement DMA (Again, is this useful? Some docs say DMA is
* slower than programmed I/O)
*
* Compile with:
@@ -47,7 +43,7 @@
* -DMODULE -c ni5010.c
*
* Insert with e.g.:
- * insmod ni5010.o io=0x300 irq=5
+ * insmod ni5010.ko io=0x300 irq=5
*/
#include <linux/module.h>
@@ -69,15 +65,15 @@
#include "ni5010.h"
-static const char *boardname = "NI5010";
-static char *version =
- "ni5010.c: v1.00 06/23/97 Jan-Pascal van Best and Andreas Mohr\n";
+static const char boardname[] = "NI5010";
+static char version[] __initdata =
+ "ni5010.c: v1.02 20060611 Jan-Pascal van Best and Andreas Mohr\n";
/* bufsize_rcv == 0 means autoprobing */
static unsigned int bufsize_rcv;
-#define jumpered_interrupts /* IRQ line jumpered on board */
-#undef jumpered_dma /* No DMA used */
+#define JUMPERED_INTERRUPTS /* IRQ line jumpered on board */
+#undef JUMPERED_DMA /* No DMA used */
#undef FULL_IODETECT /* Only detect in portlist */
#ifndef FULL_IODETECT
@@ -121,7 +117,7 @@
static int io;
static int irq;
-struct net_device * __init ni5010_probe(int unit)
+static struct net_device * __init ni5010_probe(int unit)
{
struct net_device *dev = alloc_etherdev(sizeof(struct ni5010_local));
int *port;
@@ -281,7 +277,7 @@
PRINTK2((KERN_DEBUG "%s: I/O #4 passed!\n", dev->name));
-#ifdef jumpered_interrupts
+#ifdef JUMPERED_INTERRUPTS
if (dev->irq == 0xff)
;
else if (dev->irq < 2) {
@@ -305,7 +301,7 @@
} else if (dev->irq == 2) {
dev->irq = 9;
}
-#endif /* jumpered_irq */
+#endif /* JUMPERED_INTERRUPTS */
PRINTK2((KERN_DEBUG "%s: I/O #9 passed!\n", dev->name));
/* DMA is not supported (yet?), so no use detecting it */
@@ -334,7 +330,7 @@
outw(0, IE_GP); /* Point GP at start of packet */
outb(0, IE_RBUF); /* set buffer byte 0 to 0 again */
}
- printk("// bufsize rcv/xmt=%d/%d\n", bufsize_rcv, NI5010_BUFSIZE);
+ printk("-> bufsize rcv/xmt=%d/%d\n", bufsize_rcv, NI5010_BUFSIZE);
memset(dev->priv, 0, sizeof(struct ni5010_local));
dev->open = ni5010_open;
@@ -354,11 +350,9 @@
outb(0xff, EDLC_XCLR); /* Kill all pending xmt interrupts */
printk(KERN_INFO "%s: NI5010 found at 0x%x, using IRQ %d", dev->name, ioaddr, dev->irq);
- if (dev->dma) printk(" & DMA %d", dev->dma);
+ if (dev->dma)
+ printk(" & DMA %d", dev->dma);
printk(".\n");
-
- printk(KERN_INFO "Join the NI5010 driver development team!\n");
- printk(KERN_INFO "Mail to a.mohr@mailto.de or jvbest@wi.leidenuniv.nl\n");
return 0;
out:
release_region(dev->base_addr, NI5010_IO_EXTENT);
@@ -371,7 +365,7 @@
*
* This routine should set everything up anew at each open, even
* registers that "should" only need to be set once at boot, so that
- * there is non-reboot way to recover if something goes wrong.
+ * there is a non-reboot way to recover if something goes wrong.
*/
static int ni5010_open(struct net_device *dev)
@@ -390,13 +384,13 @@
* Always allocate the DMA channel after the IRQ,
* and clean up on failure.
*/
-#ifdef jumpered_dma
+#ifdef JUMPERED_DMA
if (request_dma(dev->dma, cardname)) {
printk(KERN_WARNING "%s: Cannot get dma %#2x\n", dev->name, dev->dma);
free_irq(dev->irq, NULL);
return -EAGAIN;
}
-#endif /* jumpered_dma */
+#endif /* JUMPERED_DMA */
PRINTK3((KERN_DEBUG "%s: passed open() #2\n", dev->name));
/* Reset the hardware here. Don't forget to set the station address. */
@@ -633,7 +627,7 @@
int ioaddr = dev->base_addr;
PRINTK2((KERN_DEBUG "%s: entering ni5010_close\n", dev->name));
-#ifdef jumpered_interrupts
+#ifdef JUMPERED_INTERRUPTS
free_irq(dev->irq, NULL);
#endif
/* Put card in held-RESET state */
@@ -771,7 +765,7 @@
MODULE_PARM_DESC(io, "ni5010 I/O base address");
MODULE_PARM_DESC(irq, "ni5010 IRQ number");
-int init_module(void)
+static int __init ni5010_init_module(void)
{
PRINTK2((KERN_DEBUG "%s: entering init_module\n", boardname));
/*
@@ -792,13 +786,15 @@
return 0;
}
-void cleanup_module(void)
+static void __exit ni5010_cleanup_module(void)
{
PRINTK2((KERN_DEBUG "%s: entering cleanup_module\n", boardname));
unregister_netdev(dev_ni5010);
release_region(dev_ni5010->base_addr, NI5010_IO_EXTENT);
free_netdev(dev_ni5010);
}
+module_init(ni5010_init_module);
+module_exit(ni5010_cleanup_module);
#endif /* MODULE */
MODULE_LICENSE("GPL");
diff -urN linux-2.6.17-rc6-mm2.orig/MAINTAINERS linux-2.6.17-rc6-mm2.my/MAINTAINERS
--- linux-2.6.17-rc6-mm2.orig/MAINTAINERS 2006-06-13 19:28:17.000000000 +0200
+++ linux-2.6.17-rc6-mm2.my/MAINTAINERS 2006-06-13 19:32:03.000000000 +0200
@@ -2072,9 +2072,10 @@
S: Maintained
NI5010 NETWORK DRIVER
-P: Jan-Pascal van Best and Andreas Mohr
-M: Jan-Pascal van Best <jvbest@qv3pluto.leidenuniv.nl>
-M: Andreas Mohr <100.30936@germany.net>
+P: Jan-Pascal van Best
+M: janpascal@vanbest.org
+P: Andreas Mohr
+M: andi@lisas.de
L: netdev@vger.kernel.org
S: Maintained
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry)
2006-06-14 19:28 ` Andreas Mohr
@ 2006-06-14 20:57 ` Jan-Pascal van Best
0 siblings, 0 replies; 6+ messages in thread
From: Jan-Pascal van Best @ 2006-06-14 20:57 UTC (permalink / raw)
To: Andreas Mohr; +Cc: Horst von Brand, Andrew Morton, Pavel Machek, kernel list
Andreas Mohr wrote:
> Hi,
>
> On Tue, Jun 13, 2006 at 04:27:06PM -0400, Horst von Brand wrote:
>
>> Andreas Mohr <andi@rhlx01.fht-esslingen.de> wrote:
>>
>> [...]
>>
>>
>>> @@ -47,7 +43,7 @@
>>> * -DMODULE -c ni5010.c
>>> *
>>> * Insert with e.g.:
>>> - * insmod ni5010.o io=0x300 irq=5
>>> + * insmod ni5010.o io=0x300 irq=5
>>> */
>>>
>> Should now be .ko ;-)
>>
>
> Aaaargh... ;)
>
> Complete waste of time... but I redid it anyway.
>
> Signed-off-by: Andreas Mohr <andi@lisas.de>
>
If you're wasting your time - the note that one needs to patch ifconfig
to use the driver
is probably pretty obsolete too :-)
Jan-Pascal
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2006-06-14 20:58 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-07 14:22 NI5010 network driver -- MAINTAINERS entry Pavel Machek
2006-06-07 15:00 ` Andreas Mohr
2006-06-13 19:06 ` [PATCH -mm] NI5010 netcard cleanup (was: Re: NI5010 network driver -- MAINTAINERS entry) Andreas Mohr
2006-06-13 20:27 ` Horst von Brand
2006-06-14 19:28 ` Andreas Mohr
2006-06-14 20:57 ` Jan-Pascal van Best
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox