public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* 2.6.17-rc6 does not boot on HP dc7600u - MCFG area is not E820-reserved
@ 2006-06-15 12:20 Barry Scott
  2006-06-15 14:35 ` Barry Scott
  0 siblings, 1 reply; 3+ messages in thread
From: Barry Scott @ 2006-06-15 12:20 UTC (permalink / raw)
  To: linux-kernel

I'm trying to boot 2.6.17-rc6 with Mismatched section patches applied.

On my HP dc7600U the last messages printed are:

PCI: BUIS Bug: MCFG area is not E820-reserved
PCI: Not using MMCONFIG

Googling I found a message about a IBM laptop reporting this message
but that it did go on to boot. THere was a suggestion that the test 
should be
removed. I commented out the code and I can boot further.

Here is the code I patched.

--- arch/i386/pci/mmconfig.c~   2006-06-15 13:04:58.000000000 +0100
+++ arch/i386/pci/mmconfig.c    2006-06-15 13:04:58.000000000 +0100
@@ -194,17 +194,19 @@
        if ((pci_mmcfg_config_num == 0) ||
            (pci_mmcfg_config == NULL) ||
            (pci_mmcfg_config[0].base_address == 0))
                return;

+/* qqq
        if (!e820_all_mapped(pci_mmcfg_config[0].base_address,
                        pci_mmcfg_config[0].base_address + 
MMCONFIG_APER_SIZE,
                        E820_RESERVED)) {
                printk(KERN_ERR "PCI: BIOS Bug: MCFG area is not 
E820-reserved\n");
                printk(KERN_ERR "PCI: Not using MMCONFIG.\n");
                return;
        }
+qqq */

        printk(KERN_INFO "PCI: Using MMCONFIG\n");
        raw_pci_ops = &pci_mmcfg;
        pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;

Barry


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 2.6.17-rc6 does not boot on HP dc7600u - MCFG area is not E820-reserved
  2006-06-15 12:20 2.6.17-rc6 does not boot on HP dc7600u - MCFG area is not E820-reserved Barry Scott
@ 2006-06-15 14:35 ` Barry Scott
  0 siblings, 0 replies; 3+ messages in thread
From: Barry Scott @ 2006-06-15 14:35 UTC (permalink / raw)
  Cc: linux-kernel

Barry Scott wrote:
> I'm trying to boot 2.6.17-rc6 with Mismatched section patches applied.
>
> On my HP dc7600U the last messages printed are:
>
> PCI: BUIS Bug: MCFG area is not E820-reserved
> PCI: Not using MMCONFIG
>
> Googling I found a message about a IBM laptop reporting this message
> but that it did go on to boot. THere was a suggestion that the test 
> should be
> removed. I commented out the code and I can boot further.
>
> Here is the code I patched.
>
> --- arch/i386/pci/mmconfig.c~   2006-06-15 13:04:58.000000000 +0100
> +++ arch/i386/pci/mmconfig.c    2006-06-15 13:04:58.000000000 +0100
> @@ -194,17 +194,19 @@
>        if ((pci_mmcfg_config_num == 0) ||
>            (pci_mmcfg_config == NULL) ||
>            (pci_mmcfg_config[0].base_address == 0))
>                return;
>
> +/* qqq
>        if (!e820_all_mapped(pci_mmcfg_config[0].base_address,
>                        pci_mmcfg_config[0].base_address + 
> MMCONFIG_APER_SIZE,
>                        E820_RESERVED)) {
>                printk(KERN_ERR "PCI: BIOS Bug: MCFG area is not 
> E820-reserved\n");
>                printk(KERN_ERR "PCI: Not using MMCONFIG.\n");
>                return;
>        }
> +qqq */
>
>        printk(KERN_INFO "PCI: Using MMCONFIG\n");
>        raw_pci_ops = &pci_mmcfg;
>        pci_probe = (pci_probe & ~PCI_PROBE_MASK) | PCI_PROBE_MMCONF;
>
> Barry
>
> -
> To unsubscribe from this list: send the line "unsubscribe 
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
Chuck Ebbert's MMCONFIG patch fixes this problem for me.

Barry



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: 2.6.17-rc6 does not boot on HP dc7600u - MCFG area is not E820-reserved
@ 2006-06-16  3:00 Chuck Ebbert
  0 siblings, 0 replies; 3+ messages in thread
From: Chuck Ebbert @ 2006-06-16  3:00 UTC (permalink / raw)
  To: Barry Scott; +Cc: linux-kernel

In-Reply-To: <44915098.3070404@onelan.co.uk>

On Thu, 15 Jun 2006 13:20:40, Barry Scott wrote:

> I'm trying to boot 2.6.17-rc6 with Mismatched section patches applied.
> 
> On my HP dc7600U the last messages printed are:
> 
> PCI: BUIS Bug: MCFG area is not E820-reserved
> PCI: Not using MMCONFIG

I posted this today.  Please test.  It is less picky and will print
the address of the MMCONFIG area if it fails.

--- 2.6.17-rc6-64.orig/arch/i386/pci/mmconfig.c
+++ 2.6.17-rc6-64/arch/i386/pci/mmconfig.c
@@ -15,7 +15,9 @@
 #include <asm/e820.h>
 #include "pci.h"
 
-#define MMCONFIG_APER_SIZE (256*1024*1024)
+/* aperture is up to 256MB but BIOS may reserve less */
+#define MMCONFIG_APER_MIN	(2 * 1024*1024)
+#define MMCONFIG_APER_MAX	(256 * 1024*1024)
 
 /* Assume systems with more busses have correct MCFG */
 #define MAX_CHECK_BUS 16
@@ -197,9 +199,10 @@ void __init pci_mmcfg_init(void)
 		return;
 
 	if (!e820_all_mapped(pci_mmcfg_config[0].base_address,
-			pci_mmcfg_config[0].base_address + MMCONFIG_APER_SIZE,
+			pci_mmcfg_config[0].base_address + MMCONFIG_APER_MIN,
 			E820_RESERVED)) {
-		printk(KERN_ERR "PCI: BIOS Bug: MCFG area is not E820-reserved\n");
+		printk(KERN_ERR "PCI: BIOS Bug: MCFG area at %x is not E820-reserved\n",
+				pci_mmcfg_config[0].base_address);
 		printk(KERN_ERR "PCI: Not using MMCONFIG.\n");
 		return;
 	}
--- 2.6.17-rc6-64.orig/arch/x86_64/pci/mmconfig.c
+++ 2.6.17-rc6-64/arch/x86_64/pci/mmconfig.c
@@ -13,7 +13,10 @@
 
 #include "pci.h"
 
-#define MMCONFIG_APER_SIZE (256*1024*1024)
+/* aperture is up to 256MB but BIOS may reserve less */
+#define MMCONFIG_APER_MIN	(2 * 1024*1024)
+#define MMCONFIG_APER_MAX	(256 * 1024*1024)
+
 /* Verify the first 16 busses. We assume that systems with more busses
    get MCFG right. */
 #define MAX_CHECK_BUS 16
@@ -175,9 +178,10 @@ void __init pci_mmcfg_init(void)
 		return;
 
 	if (!e820_all_mapped(pci_mmcfg_config[0].base_address,
-			pci_mmcfg_config[0].base_address + MMCONFIG_APER_SIZE,
+			pci_mmcfg_config[0].base_address + MMCONFIG_APER_MIN,
 			E820_RESERVED)) {
-		printk(KERN_ERR "PCI: BIOS Bug: MCFG area is not E820-reserved\n");
+		printk(KERN_ERR "PCI: BIOS Bug: MCFG area at %x is not E820-reserved\n",
+				pci_mmcfg_config[0].base_address);
 		printk(KERN_ERR "PCI: Not using MMCONFIG.\n");
 		return;
 	}
@@ -190,7 +194,8 @@ void __init pci_mmcfg_init(void)
 	}
 	for (i = 0; i < pci_mmcfg_config_num; ++i) {
 		pci_mmcfg_virt[i].cfg = &pci_mmcfg_config[i];
-		pci_mmcfg_virt[i].virt = ioremap_nocache(pci_mmcfg_config[i].base_address, MMCONFIG_APER_SIZE);
+		pci_mmcfg_virt[i].virt = ioremap_nocache(pci_mmcfg_config[i].base_address,
+							 MMCONFIG_APER_MAX);
 		if (!pci_mmcfg_virt[i].virt) {
 			printk("PCI: Cannot map mmconfig aperture for segment %d\n",
 			       pci_mmcfg_config[i].pci_segment_group_number);
-- 
Chuck

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2006-06-16  3:03 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-15 12:20 2.6.17-rc6 does not boot on HP dc7600u - MCFG area is not E820-reserved Barry Scott
2006-06-15 14:35 ` Barry Scott
  -- strict thread matches above, loose matches on Subject: below --
2006-06-16  3:00 Chuck Ebbert

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox