From: "Martin J. Bligh" <mbligh@aracnet.com>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
viro@parcelfarce.linux.theplanet.co.uk, Andi Kleen <ak@suse.de>
Subject: [PATCH] zero out i_blocks in get_pipe_inode
Date: Tue, 11 Nov 2003 15:04:58 -0800 [thread overview]
Message-ID: <44940000.1068591898@flay> (raw)
Fished from the 2.4 SuSE tree, which I'm trawling through.
This seems like a perfectly reasonable thing to do to me,
there was some discussion earlier on IRC. Some extracts from
the conversation were "returning random old data from the kernel
is always a bug", "any userland code that trips on that one is
broken", and "iirc it broke postfix". Nobody seemed to think it
was actively evil, and it seems to fix a bug ;-)
diff -purN -X /home/mbligh/.diff.exclude virgin/fs/pipe.c pipe_init/fs/pipe.c
--- virgin/fs/pipe.c 2003-10-14 15:50:30.000000000 -0700
+++ pipe_init/fs/pipe.c 2003-11-11 12:13:32.000000000 -0800
@@ -527,6 +527,7 @@ static struct inode * get_pipe_inode(voi
inode->i_gid = current->fsgid;
inode->i_atime = inode->i_mtime = inode->i_ctime = CURRENT_TIME;
inode->i_blksize = PAGE_SIZE;
+ inode->i_blocks = 0;
return inode;
fail_iput:
next reply other threads:[~2003-11-11 22:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-11-11 23:04 Martin J. Bligh [this message]
2003-11-11 22:48 ` [PATCH] zero out i_blocks in get_pipe_inode Andrew Morton
2003-11-11 22:50 ` Andi Kleen
2003-11-11 23:36 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44940000.1068591898@flay \
--to=mbligh@aracnet.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox