From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org, ganguly.s@samsung.com
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
peterz@infradead.org, Waiman.Long@hp.com,
raghavendra.kt@linux.vnet.ibm.com, oleg@redhat.com,
linux-kernel@vger.kernel.org,
SHARAN ALLUR <sharan.allur@samsung.com>,
torvalds@linux-foundation.org
Subject: Re: [RFC] arm: Add for atomic half word exchange
Date: Tue, 19 May 2015 11:51:21 +0200 [thread overview]
Message-ID: <4497461.dn0jdrPFfy@wuerfel> (raw)
In-Reply-To: <1122007906.400701432028368414.JavaMail.weblogic@ep2mlwas07a>
On Tuesday 19 May 2015 09:39:33 Sarbojit Ganguly wrote:
> Since 16 bit half word exchange was not there and MCS based qspinlock by Waiman's xchg_tail() requires an atomic exchange on a half word,
> here is a small modification to __xchg() code.
We have discussed a similar patch before, see
https://lkml.org/lkml/2015/2/25/390
> #if __LINUX_ARM_ARCH__ >= 6
> @@ -50,6 +52,23 @@
> : "r" (x), "r" (ptr)
> : "memory", "cc");
> break;
> + /*
> + * halfword exclusive exchange
> + * This is new implementation as qspinlock
> + * wants 16 bit atomic CAS.
> + */
> + case 2:
> + asm volatile("@ __xchg2\n"
> + "1: ldrexh %0, [%3]\n"
> + " strexh %1, %2, [%3]\n"
> + " teq %1, #0\n"
> + " bne 1b"
> + : "=&r" (ret), "=&r" (tmp)
> + : "r" (x), "r" (ptr)
> + : "memory", "cc");
> + break;
> case 4:
> asm volatile("@ __xchg4\n"
> "1: ldrex %0, [%3]\n"
Please try to find a way to make this compile when CONFIG_CPU_V6
is set.
Arnd
next prev parent reply other threads:[~2015-05-19 9:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-19 9:39 [RFC] arm: Add for atomic half word exchange Sarbojit Ganguly
2015-05-19 9:51 ` Arnd Bergmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2015-05-19 11:20 Sarbojit Ganguly
2015-05-19 11:42 ` Arnd Bergmann
2015-05-19 12:13 ` Russell King - ARM Linux
2015-05-19 12:43 ` Peter Zijlstra
2015-05-20 5:09 Sarbojit Ganguly
2015-05-20 6:51 ` Arnd Bergmann
2015-06-02 5:49 Sarbojit Ganguly
2015-06-02 6:11 ` Raghavendra K T
2015-06-02 6:21 Sarbojit Ganguly
2015-06-02 10:49 ` Arnd Bergmann
2015-06-05 1:17 Re: " Sarbojit Ganguly
2015-06-05 12:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4497461.dn0jdrPFfy@wuerfel \
--to=arnd@arndb.de \
--cc=Waiman.Long@hp.com \
--cc=ganguly.s@samsung.com \
--cc=hpa@zytor.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=oleg@redhat.com \
--cc=peterz@infradead.org \
--cc=raghavendra.kt@linux.vnet.ibm.com \
--cc=sharan.allur@samsung.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox