From: Mark Lord <lkml@rtr.ca>
To: Al Boldi <a1426z@gawab.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: LibPATA/ATA Errors Continue - Will there be a fix for this?
Date: Tue, 20 Jun 2006 12:25:06 -0400 [thread overview]
Message-ID: <44982162.2020006@rtr.ca> (raw)
In-Reply-To: <200606201815.54318.a1426z@gawab.com>
Al Boldi wrote:
>
> I once sent a patch to -mm:
>
..
>>> -#define OK_STAT(stat,good,bad) (((stat)&((good)|(bad)))==(good))
>>> +#define OK_STAT(stat,good,bad) (((stat)&((good)|(bad)))==((stat)&(good)))
>>> #define BAD_R_STAT (BUSY_STAT | ERR_STAT)
>>> #define BAD_W_STAT (BAD_R_STAT | WRERR_STAT)
>>> #define BAD_STAT (BAD_R_STAT | DRQ_STAT)
>> Assuming hdb is a CDROM/optical drive, then this change makes sense for
>> that. But I don't think it is a valid (good) change for regular ATA disks.
>>
>> A more complex patch is required, one which correctly handles each drive
>> type.
That patch was very ATAPI-specific, and would break other things.
It also would not correctly help anything in Justin's case.
-ml
next prev parent reply other threads:[~2006-06-20 16:25 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-20 15:15 LibPATA/ATA Errors Continue - Will there be a fix for this? Al Boldi
2006-06-20 15:48 ` Justin Piszcz
2006-06-20 16:25 ` Mark Lord [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-06-20 12:17 Justin Piszcz
2006-06-20 13:01 ` Mark Lord
2006-06-20 13:03 ` Justin Piszcz
2006-06-20 14:23 ` David Greaves
2006-06-20 15:45 ` David Greaves
2006-06-20 15:46 ` Justin Piszcz
2006-06-20 22:20 ` David Greaves
2006-06-20 22:22 ` Justin Piszcz
2006-06-21 11:39 ` Justin Piszcz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44982162.2020006@rtr.ca \
--to=lkml@rtr.ca \
--cc=a1426z@gawab.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox