public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Re: LibPATA/ATA Errors Continue - Will there be a fix for this?
@ 2006-06-20 15:15 Al Boldi
  2006-06-20 15:48 ` Justin Piszcz
  2006-06-20 16:25 ` Mark Lord
  0 siblings, 2 replies; 12+ messages in thread
From: Al Boldi @ 2006-06-20 15:15 UTC (permalink / raw)
  To: linux-kernel

Justin Piszcz wrote:
> On Tue, 20 Jun 2006, Mark Lord wrote:
> > Justin Piszcz wrote:
> >> Should someone comment this code out that produces the printk()'s as
> >> these are useless information as there is no problem with the disk?
> >
> > MMm.. probably "barrier" commands that the drive doesn't like.
> > Pity those messages don't also dump the failed opcode.
> >
> >> Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: status=0x51 {
> >> DriveReady SeekComplete Error }
> >> Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: error=0x04 {
> >> DriveStatusError }
> >> Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: no sense translation
> >> for status: 0x51
> >> Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: status=0x51 {
> >> DriveReady SeekComplete Error }
>
> Mark, what would be the proper direction to move towards?  Is Jeff or
> another SATA/ATA maintainer going to have to look at this or is there
> something else I can do, or?

I once sent a patch to -mm:

Mark Lord wrote:
> Al Boldi wrote:
>> Also apply this one to get rid of this message:
>>
>> 	hdb: set_drive_speed_status: status=0x40 { DriveReady }
>> 	ide: failed opcode was: unknown
>>
>> Maybe someone on the ide list can comment on this first though.
>>
>> --- 16/include/linux/ide.h.orig	2006-03-31 19:12:51.000000000 +0300
>> +++ 16/include/linux/ide.h	2006-04-23 13:06:32.000000000 +0300
>> @@ -120,7 +120,7 @@ typedef unsigned char	byte;	/* used ever
>>  #define IDE_BCOUNTL_REG		IDE_LCYL_REG
>>  #define IDE_BCOUNTH_REG		IDE_HCYL_REG
>>
>> -#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==(good))
>> +#define OK_STAT(stat,good,bad)	(((stat)&((good)|(bad)))==((stat)&(good)))
>>  #define BAD_R_STAT		(BUSY_STAT   | ERR_STAT)
>>  #define BAD_W_STAT		(BAD_R_STAT  | WRERR_STAT)
>>  #define BAD_STAT		(BAD_R_STAT  | DRQ_STAT)
>
> Assuming hdb is a CDROM/optical drive, then this change makes sense for
> that. But I don't think it is a valid (good) change for regular ATA disks.
>
> A more complex patch is required, one which correctly handles each drive
> type.

Thanks!

--
Al


^ permalink raw reply	[flat|nested] 12+ messages in thread
* LibPATA/ATA Errors Continue - Will there be a fix for this?
@ 2006-06-20 12:17 Justin Piszcz
  2006-06-20 13:01 ` Mark Lord
  0 siblings, 1 reply; 12+ messages in thread
From: Justin Piszcz @ 2006-06-20 12:17 UTC (permalink / raw)
  To: linux-kernel; +Cc: linux-ide, jgarzik, Mark Lord

Jeff,

I've done many RSYNCs to this disk (writing is what makes these errors 
seem to occur) and I have MD5's the files on both sides, they are OK on 
each side.

Should someone comment this code out that produces the printk()'s as these 
are useless information as there is no problem with the disk?

Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: status=0x51 { 
DriveReady SeekComplete Error }
Jun 20 03:14:20 p34 kernel: [4339456.678000] ata3: error=0x04 { 
DriveStatusError }
Jun 20 03:20:27 p34 kernel: [4339823.900000] ata3: status=0x51 { 
DriveReady SeekComplete Error }
Jun 20 03:20:27 p34 kernel: [4339823.900000] ata3: error=0x04 { 
DriveStatusError }
Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: no sense translation 
for status: 0x51
Jun 20 03:36:44 p34 kernel: [4340801.772000] ata3: status=0x51 { 
DriveReady SeekComplete Error }
Jun 20 03:41:04 p34 kernel: [4341061.844000] ata3: no sense translation 
for status: 0x51
Jun 20 03:41:04 p34 kernel: [4341061.844000] ata3: status=0x51 { 
DriveReady SeekComplete Error }
Jun 20 03:46:27 p34 kernel: [4341384.974000] ata3: no sense translation 
for status: 0x51
Jun 20 03:46:27 p34 kernel: [4341384.974000] ata3: status=0x51 { 
DriveReady SeekComplete Error }

Justin.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2006-06-21 11:39 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-20 15:15 LibPATA/ATA Errors Continue - Will there be a fix for this? Al Boldi
2006-06-20 15:48 ` Justin Piszcz
2006-06-20 16:25 ` Mark Lord
  -- strict thread matches above, loose matches on Subject: below --
2006-06-20 12:17 Justin Piszcz
2006-06-20 13:01 ` Mark Lord
2006-06-20 13:03   ` Justin Piszcz
2006-06-20 14:23   ` David Greaves
2006-06-20 15:45     ` David Greaves
2006-06-20 15:46       ` Justin Piszcz
2006-06-20 22:20         ` David Greaves
2006-06-20 22:22           ` Justin Piszcz
2006-06-21 11:39           ` Justin Piszcz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox