public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Paul Fulghum <paulkf@microgate.com>
To: Shaun Jackman <sjackman@gmail.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: TL16C752B DUART: MCR_OUT2 disables interrupts
Date: Tue, 20 Jun 2006 15:26:47 -0500	[thread overview]
Message-ID: <44985A07.9080807@microgate.com> (raw)
In-Reply-To: <7f45d9390606201307yfdb8aadn4d00a6afeba0b09b@mail.gmail.com>

Shaun Jackman wrote:
> The datasheet I have for the TL16C752B labels the MCR_OUT1 bit as
> `FIFO Rdy enable' and the MCR_OUT2 bit as `IRQ enable'. The latter bit
> concerns me. The 8250.c driver sets MCR_OUT2 by default; however, if
> the user space clears MCR_OUT2 (through an ioctl TIOCMSET operation or
> similar), it seems to me that interrupts for that UART will stop
> working. Can someone confirm my suspicion?
> 
> I'd expect that clearing/setting the OUT1 and OUT2 pins from user
> space should be an innocuous operation. Disabling interrupts is a
> fairly nasty side effect.

The old 16550 OUT2 output (MCR:3) used to be a truly
independant control output that was commonly used
with an external gate to connect/disconnect the
interrupt request to the ISA bus.

Reading the TL16C752B datasheet, it seems pretty clear
that this gating is performed internal to the device.
MCR:3 is no longer an independant, general purpose I/O.

The result is the same though: If you dink around with
MCR:3 you could disable interrupts in either case.

So I don't see this as more or less of a problem than
other 16550 type devices.

-- 
Paul Fulghum
Microgate Systems, Ltd.

  reply	other threads:[~2006-06-20 20:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-20 20:07 TL16C752B DUART: MCR_OUT2 disables interrupts Shaun Jackman
2006-06-20 20:26 ` Paul Fulghum [this message]
2006-06-20 20:35   ` Shaun Jackman
2006-06-20 20:37     ` Paul Fulghum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44985A07.9080807@microgate.com \
    --to=paulkf@microgate.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sjackman@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox