From: Jeff Garzik <jeff@garzik.org>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Netdev List <netdev@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Linus Torvalds <torvalds@osdl.org>
Subject: Re: Sanitise ethtool.h and mii.h for userspace.
Date: Tue, 20 Jun 2006 21:18:27 -0400 [thread overview]
Message-ID: <44989E63.9010300@garzik.org> (raw)
In-Reply-To: <200606202308.k5KN83bT013398@hera.kernel.org>
Linux Kernel Mailing List wrote:
> commit c3ce7e203af5d8eab7c3390fc991a1fcb152f741
> tree 43b0837c42a1deb5b0f87800bf6a5ed8eea2eafe
> parent 56142536868a2be34f261ed8fdca1610f8a73fbd
> author David Woodhouse <dwmw2@shinybook.infradead.org> Sat, 29 Apr 2006 01:53:47 +0100
> committer David Woodhouse <dwmw2@infradead.org> Sat, 29 Apr 2006 01:53:47 +0100
>
> Sanitise ethtool.h and mii.h for userspace.
>
> They shouldn't be using 'u32' et al in structures which are used for
> communication with userspace. Switch to the proper types (__u32 etc).
>
> Signed-off-by: David Woodhouse <dwmw2@infradead.org>
How can reviewers make an informed decision, when you completely failed
to note:
* This breaks the primary userspace user of this header, ethtool(8)
* The patch was NAK'd (and I don't even get a "Naked-by:" header :))
* Despite knowing all this for quite some time, no associated userspace
fix patch has ever appeared.
If you are going to break stuff, AT LEAST TELL PEOPLE IN ALL CAPS ABOUT
IT, rather than providing the highly deceptive description as above.
And be courteous enough to help fix the breakage, if you please.
Jeff, ethtool maintainer
next parent reply other threads:[~2006-06-21 1:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606202308.k5KN83bT013398@hera.kernel.org>
2006-06-21 1:18 ` Jeff Garzik [this message]
2006-06-21 8:23 ` Sanitise ethtool.h and mii.h for userspace David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44989E63.9010300@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox