Re: [PATCH 00/11] Task watchers: Introduction

[Peter Williams <pwil3058@bigpond.net.au>]

Peter Williams wrote:
> Matt Helsley wrote:
>> On Wed, 2006-06-21 at 15:41 +1000, Peter Williams wrote:
>>> On a related note, I can't see where the new task's notify field gets 
>>> initialized during fork.
>>
>> It's initialized in kernel/sys.c:notify_per_task_watchers(), which calls
>> RAW_INIT_NOTIFIER_HEAD(&task->notify) in response to WATCH_TASK_INIT.
> 
> I think that's too late.  It needs to be done at the start of 
> notify_watchers() before any other watchers are called for the new task.

On second thoughts, it would simpler just before the WATCH_TASK_INIT 
call in copy_process() in fork.c.  It can be done unconditionally there.

Peter
-- 
Peter Williams                                   pwil3058@bigpond.net.au

"Learning, n. The kind of ignorance distinguishing the studious."
  -- Ambrose Bierce