From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964881AbWFVIWd (ORCPT ); Thu, 22 Jun 2006 04:22:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964859AbWFVIWd (ORCPT ); Thu, 22 Jun 2006 04:22:33 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:24773 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S964789AbWFVIWc (ORCPT ); Thu, 22 Jun 2006 04:22:32 -0400 Message-ID: <449A533E.4090201@pobox.com> Date: Thu, 22 Jun 2006 04:22:22 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.4 (X11/20060614) MIME-Version: 1.0 To: Herbert Xu CC: Alan Cox , snakebyte@gmx.de, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, davem@davemloft.net Subject: Re: Memory corruption in 8390.c ? (was Re: Possible leaks in network drivers) References: <1150909982.15275.100.camel@localhost.localdomain> <20060622023029.GA6156@gondor.apana.org.au> In-Reply-To: <20060622023029.GA6156@gondor.apana.org.au> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.1.3 on srv5.dvmed.net summary: Content analysis details: (-4.2 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Herbert Xu wrote: > This patch uses pskb_expand_head to expand the existing skb and linearize Seems sane to me. > it if needed. Actually, someone should sift through every instance of > skb_pad on a non-linear skb as they do not fit the reasons why this was > originally created. Non-linear skbs smaller than ETH_ZLEN seem unlikely. Overall, the skb_pad() changes were made over a short span of time, often to older and under-used drivers, so I would not be surprised to find rough edges or the occasional bug. Jeff