public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Antonino A. Daplas" <adaplas@gmail.com>
To: Edgar Hucek <hostmaster@ed-soft.at>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/1] New Framebuffer for Intel based Macs [try #3]
Date: Thu, 22 Jun 2006 18:49:58 +0800	[thread overview]
Message-ID: <449A75D6.7010200@gmail.com> (raw)
In-Reply-To: <4499A25A.1020508@ed-soft.at>

Edgar Hucek wrote:
> This patch add a new framebuffer driver for the Intel Based macs.
> This framebuffer is needed when booting from EFI to get something
> out the box   ;) 
> [try #2] Removed unused and untested code in this version of the patch.
> [try #3] Just cleanup to meet the coding guideline.
> 
> Signed-off-by: Edgar Hucek <hostmaster@ed-soft.at>
Acked-by: Antonino Daplas <adaplas@pol.net>

I'll pick this up if Andrew or Linus doesn't.

Tony

> +#define	DEFAULT_FB_MEM	1024*1024*16

nitpick: parenthesis around the value?


> +
> +static struct platform_device imacfb_device = {
> +	.name	= "imacfb",
> +};

You might update this sometime in the future to use
platform_device_alloc().


      reply	other threads:[~2006-06-22 10:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-21 19:47 [PATCH 1/1] New Framebuffer for Intel based Macs [try #3] Edgar Hucek
2006-06-22 10:49 ` Antonino A. Daplas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449A75D6.7010200@gmail.com \
    --to=adaplas@gmail.com \
    --cc=hostmaster@ed-soft.at \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox