* [ patch -mm1 04/11 ] gpio-patchset-fixups: request-region
@ 2006-06-22 18:51 Jim Cromie
0 siblings, 0 replies; only message in thread
From: Jim Cromie @ 2006-06-22 18:51 UTC (permalink / raw)
To: Andrew Morton; +Cc: Linux kernel
diff.13-fix-request-region
Usage of request_region() was wrong ( returns 0 on error - docpatch sent
to trivial ).
This fixes it, and clarifies the err-msg.
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
diff -ruNp -X dontdiff -X exclude-diffs 17-mm-pre0/drivers/char/pc8736x_gpio.c 13/drivers/char/pc8736x_gpio.c
--- 17-mm-pre0/drivers/char/pc8736x_gpio.c 2006-06-20 20:42:39.000000000 -0600
+++ 13/drivers/char/pc8736x_gpio.c 2006-06-21 10:31:31.000000000 -0600
@@ -297,9 +297,12 @@ static int __init pc8736x_gpio_init(void
pc8736x_gpio_base = (superio_inb(SIO_BASE_HADDR) << 8
| superio_inb(SIO_BASE_LADDR));
- if (request_region(pc8736x_gpio_base, 16, DEVNAME))
- dev_info(&pdev->dev, "GPIO ioport %x reserved\n",
- pc8736x_gpio_base);
+ if (!request_region(pc8736x_gpio_base, 16, DEVNAME)) {
+ dev_err(&pdev->dev, "GPIO ioport %x busy\n",
+ pc8736x_gpio_base);
+ return -ENODEV;
+ }
+ dev_info(&pdev->dev, "GPIO ioport %x reserved\n", pc8736x_gpio_base);
r = register_chrdev(major, DEVNAME, &pc8736x_gpio_fops);
if (r < 0) {
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2006-06-22 18:51 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-22 18:51 [ patch -mm1 04/11 ] gpio-patchset-fixups: request-region Jim Cromie
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox