public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] cardbus: revert IO window limit
@ 2006-06-22  6:48 Pekka J Enberg
  2006-06-22  7:11 ` Andrew Morton
  0 siblings, 1 reply; 26+ messages in thread
From: Pekka J Enberg @ 2006-06-22  6:48 UTC (permalink / raw)
  To: akpm; +Cc: alesan, torvalds, linux-kernel

From: Pekka Enberg <penberg@cs.helsinki.fi>

This patch reverts commit 4196c3af25d98204216a5d6c37ad2cb303a1f2bf "cardbus:
limit IO windows to 256 bytes" which breaks Alessio Sangalli's machine boot
when APM support is enabled. See http://lkml.org/lkml/2006/6/16/33 for
description of the problem.

Cc: Alessio Sangalli <alesan@manoweb.com>
Cc: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Pekka Enberg <penberg@cs.helsinki.fi>
---

diff --git a/drivers/pci/setup-bus.c b/drivers/pci/setup-bus.c
index 28ce3a7..657be94 100644
--- a/drivers/pci/setup-bus.c
+++ b/drivers/pci/setup-bus.c
@@ -40,7 +40,7 @@ #define ROUND_UP(x, a)		(((x) + (a) - 1)
  * FIXME: IO should be max 256 bytes.  However, since we may
  * have a P2P bridge below a cardbus bridge, we need 4K.
  */
-#define CARDBUS_IO_SIZE		(256)
+#define CARDBUS_IO_SIZE		(4*1024)
 #define CARDBUS_MEM_SIZE	(32*1024*1024)
 
 static void __devinit

^ permalink raw reply related	[flat|nested] 26+ messages in thread
* Re: [PATCH] cardbus: revert IO window limit
@ 2006-06-30 22:03 Daniel Ritz
  2006-06-30 22:18 ` Linus Torvalds
  2006-07-12  6:54 ` Alessio Sangalli
  0 siblings, 2 replies; 26+ messages in thread
From: Daniel Ritz @ 2006-06-30 22:03 UTC (permalink / raw)
  To: Alessio Sangalli, Linus Torvalds
  Cc: Dave Jones, Alan Cox, Andrew Morton, Pekka Enberg, linux-kernel

> Ok. We don't actually have any quirks at all for the 82440MX, and that's 
> almost certainly _not_ because it doesn't do something strange (all Intel 
> host bridges have magic IO ranges), but simply because we haven't hit it 
> yet.
> 
> And I can't find the docs for the PCI config space for that dang thing.
> 
> I bet that there's some magic SMBus IO-range that the 440MX decodes using 
> a special magic config setting.
> 
> Has anybody found the config space docs for the 82440MX? 

nope. but from the docs available i would _guess_ this thing is really
similar to the 82443BX/82371AB combination. at least the SMBus base address
register is hidden at the very same place (32bit at 0x90 in function 3 of the
"south" brigde)...so the attached little patch might be enough to fix things...

Alessio, could you try that one on top of a kernel that shows the problem?

rgds
-daniel

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 4364d79..1d26a64 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -401,6 +401,8 @@ static void __devinit quirk_piix4_acpi(s
 	piix4_io_quirk(dev, "PIIX4 devres J", 0x7c, 1 << 20);
 }
 DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_82371AB_3,	quirk_piix4_acpi );
+DECLARE_PCI_FIXUP_HEADER(PCI_VENDOR_ID_INTEL,	PCI_DEVICE_ID_INTEL_82443MX_3,	quirk_piix4_acpi );
+
 
 /*
  * ICH4, ICH4-M, ICH5, ICH5-M ACPI: Three IO regions pointed to by longwords at

^ permalink raw reply related	[flat|nested] 26+ messages in thread
* RE: [PATCH] cardbus: revert IO window limit
@ 2006-07-05 18:29 Mallick, Asit K
  0 siblings, 0 replies; 26+ messages in thread
From: Mallick, Asit K @ 2006-07-05 18:29 UTC (permalink / raw)
  To: Linus Torvalds, Dave Jones, Li, Shaohua, Arjan van de Ven
  Cc: Alessio Sangalli, Andrew Morton, alan, penberg,
	Linux Kernel Mailing List, ink, dtor_core

I am trying to find the register information. 440MX is an integration of
440BX north-bridge without AGP and PIIX4E (82371EB). PIIX4 quirk should
cover the ACPI and SMBus related I/O registers. Is there a pci dump for
this machine?

Thanks,
Asit


Linus Torvalds <mailto:torvalds@osdl.org> wrote on Friday, June 30, 2006
3:15 PM:

> On Fri, 30 Jun 2006, Dave Jones wrote:
>>  >
>>  > http://www.codemonkey.org.uk/cruft/440/
>>  > There's an assortment of docs for the other flavour Intel PCIsets
>> from  > that era in the same dir. 
>> 
>> Hrmm, actually that seems to have everything *but* config space
>> definitions. 
> 
> Yeah, I found those on the intel site too, but nothing with config
> space 
> access info.
> 
> It's surprising, actually. I usually have no trouble finding chipset
> config space info for intel chipsets.
> 
> Adding a few Intel people to the list, in the hope that they would
> know at 
> least the right person to ask.
> 
> Guys: the problem is that the 440MX (PCI ID: 8086:7194) seems to have
> some 
> magic IO register stuff again (probably ACPI or SMBus as usual), and
> we 
> don't know about them, and we don't have a quirk, so when the cardbus
> IO 
> range gets allocated, it can clash and cause trouble.
> 
> No docs seem to say _what_ the magic IO addresses are.. Pls help!
> 
> 		Linus

^ permalink raw reply	[flat|nested] 26+ messages in thread
end of thread, other threads:[~2006-07-13  6:27 UTC | newest]

Thread overview: 26+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-22  6:48 [PATCH] cardbus: revert IO window limit Pekka J Enberg
2006-06-22  7:11 ` Andrew Morton
2006-06-22  7:53   ` Alessio Sangalli
2006-06-22 11:35   ` Alan Cox
2006-06-22 16:18     ` Linus Torvalds
2006-06-22 16:36       ` Andrew Morton
2006-06-22 17:07         ` Linus Torvalds
2006-06-22 20:01           ` Alessio Sangalli
2006-06-22 21:27           ` Alessio Sangalli
2006-06-30  4:34             ` Pekka Enberg
2006-06-30 19:10             ` Linus Torvalds
2006-06-30 19:19               ` Dave Jones
2006-06-30 19:26                 ` Dave Jones
2006-06-30 22:15                   ` Linus Torvalds
2006-06-22 16:16   ` Linus Torvalds
  -- strict thread matches above, loose matches on Subject: below --
2006-06-30 22:03 Daniel Ritz
2006-06-30 22:18 ` Linus Torvalds
2006-06-30 23:09   ` Daniel Ritz
2006-06-30 23:21     ` Linus Torvalds
2006-07-05  6:56       ` Pekka J Enberg
2006-07-12  7:55       ` Alessio Sangalli
2006-07-12 15:18         ` Linus Torvalds
2006-07-13  6:29           ` Alessio Sangalli
2006-07-12  7:29   ` Alessio Sangalli
2006-07-12  6:54 ` Alessio Sangalli
2006-07-05 18:29 Mallick, Asit K

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox