From: Jeff Garzik <jeff@garzik.org>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: Greg KH <gregkh@suse.de>, Andrew Morton <akpm@osdl.org>,
bcasavan@sgi.com
Subject: Re: [PATCH] PCI: Move various PCI IDs to header file
Date: Thu, 22 Jun 2006 21:29:47 -0400 [thread overview]
Message-ID: <449B440B.7010407@garzik.org> (raw)
In-Reply-To: <200606222300.k5MN0uPW000741@hera.kernel.org>
Linux Kernel Mailing List wrote:
> diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
> index 8a29ce3..27d6587 100644
> --- a/drivers/scsi/sata_vsc.c
> +++ b/drivers/scsi/sata_vsc.c
> @@ -433,13 +433,14 @@ err_out:
>
>
> /*
> - * 0x1725/0x7174 is the Vitesse VSC-7174
> - * 0x8086/0x3200 is the Intel 31244, which is supposed to be identical
> - * compatibility is untested as of yet
> + * Intel 31244 is supposed to be identical.
> + * Compatibility is untested as of yet.
> */
> static const struct pci_device_id vsc_sata_pci_tbl[] = {
> - { 0x1725, 0x7174, PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 },
> - { 0x8086, 0x3200, PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 },
> + { PCI_VENDOR_ID_VITESSE, PCI_DEVICE_ID_VITESSE_VSC7174,
> + PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 },
> + { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_GD31244,
> + PCI_ANY_ID, PCI_ANY_ID, 0x10600, 0xFFFFFF, 0 },
> { }
> };
>
WTF? This is a REGRESSION from the repeatedly expressed desire -- clear
throughout libata -- that single-use PCI device IDs should not ever
receive PCI_DEVICE_ID_xxx constants.
I'm going to queue up a revert patch for this silliness.
Next time, please let the relevant maintainer(s) know when you are
touching their driver, so they have a chance to filter out the crap.
This was -never- sent to me or linux-ide, or otherwise brought to the
attention of the maintainers.
Jeff
next parent reply other threads:[~2006-06-23 1:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606222300.k5MN0uPW000741@hera.kernel.org>
2006-06-23 1:29 ` Jeff Garzik [this message]
2006-06-23 1:51 ` [PATCH] PCI: Move various PCI IDs to header file Randy.Dunlap
2006-06-23 2:02 ` Jeff Garzik
2006-07-05 15:55 ` Brent Casavant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449B440B.7010407@garzik.org \
--to=jeff@garzik.org \
--cc=akpm@osdl.org \
--cc=bcasavan@sgi.com \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox