public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Corey Minyard <minyard@acm.org>
To: Matt Domsch <Matt_Domsch@dell.com>
Cc: Peter Palfrader <peter@palfrader.org>,
	openipmi-developer@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [Openipmi-developer] BUG: soft lockup detected on CPU#1, ipmi_si
Date: Fri, 23 Jun 2006 18:44:48 -0500	[thread overview]
Message-ID: <449C7CF0.4000002@acm.org> (raw)
In-Reply-To: <20060623025649.GE15027@lists.us.dell.com>

I also had a report from Matt that running the driver full-bore caused
the mouse to go haywire.  I did some testing and the mouse didn't go
haywire, but my keyboard did.  I changed the udelay(1) to schedule() and
kipmi0 is running at 100% as I type right now, and things seem to be
running smoothly.  Testing the performance, I got 4.5ms per message for
a get device id, which was the same as I saw before the change.  So I
think this change is a good idea.

I'll let Peter test it out when he gets his machines back, and if it all
looks good I'll do a patch.

Thanks,

-Corey

Matt Domsch wrote:
> On Thu, Jun 22, 2006 at 09:03:12AM -0500, Corey Minyard wrote:
>   
>> Peter, can you make a code change for me and try something out?
>>
>> If possible, could you change the call to udelay(1) in the function
>> ipmi_thread() in drivers/char/ipmi_si_intf.c to be a call to schedule()
>> instead?  I'm guessing that will fix this problem.
>>     
>
> won't that cause the thread to be scheduled out for at least one timer
> tick (1-10ms depending on HZ), especially as it's at nice 19?  This
> will cause the commands to be quite slow, which was the primary reason
> for the kthread here in the first place.
>
> Thanks,
> Matt
>
>   


  parent reply	other threads:[~2006-06-23 23:44 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-13 23:35 BUG: soft lockup detected on CPU#1, ipmi_si Peter Palfrader
2006-06-19  3:59 ` [Openipmi-developer] " Corey Minyard
2006-06-19  9:38   ` Peter Palfrader
2006-06-22 14:03     ` Corey Minyard
2006-06-23  2:56       ` Matt Domsch
2006-06-23 14:55         ` Corey Minyard
2006-06-23 23:44         ` Corey Minyard [this message]
2006-06-24 19:37           ` Matt Domsch
2006-06-25  1:00       ` Peter Palfrader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=449C7CF0.4000002@acm.org \
    --to=minyard@acm.org \
    --cc=Matt_Domsch@dell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=openipmi-developer@lists.sourceforge.net \
    --cc=peter@palfrader.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox