From: "Andi Kleen" <ak@suse.de>
To: torvalds@osdl.org
Cc: discuss@x86-64.org, akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [20/82] i386: Panic the system when a NUMA kernel doesn't run on IBM NUMA
Date: Sat, 24 Jun 2006 02:19:28 +0200 [thread overview]
Message-ID: <449C8510.mailCWD11E44E@suse.de> (raw)
It has been broken forever anywhere else and is not too useful
anyways so best to disable it.
Signed-off-by: Andi Kleen <ak@suse.de>
---
arch/i386/Kconfig | 3 +++
arch/i386/kernel/srat.c | 8 ++++++++
2 files changed, 11 insertions(+)
Index: linux/arch/i386/kernel/srat.c
===================================================================
--- linux.orig/arch/i386/kernel/srat.c
+++ linux/arch/i386/kernel/srat.c
@@ -312,6 +312,14 @@ int __init get_memcfg_from_srat(void)
int tables = 0;
int i = 0;
+ extern int use_cyclone;
+ if (use_cyclone == 0) {
+ /* Make sure user sees something */
+ static const char s[] __initdata = "Not an IBM x440/NUMAQ. Don't use i386 CONFIG_NUMA anywhere else.";
+ early_printk(s);
+ panic(s);
+ }
+
if (ACPI_FAILURE(acpi_find_root_pointer(ACPI_PHYSICAL_ADDRESSING,
rsdp_address))) {
printk("%s: System description tables not found\n",
Index: linux/arch/i386/Kconfig
===================================================================
--- linux.orig/arch/i386/Kconfig
+++ linux/arch/i386/Kconfig
@@ -523,6 +523,9 @@ config NUMA
depends on SMP && HIGHMEM64G && (X86_NUMAQ || X86_GENERICARCH || (X86_SUMMIT && ACPI))
default n if X86_PC
default y if (X86_NUMAQ || X86_SUMMIT)
+ help
+ NUMA support. Note this only works on IBM x440 or IBM NUMAQ.
+ Don't try to use it anywhere else.
comment "NUMA (Summit) requires SMP, 64GB highmem support, ACPI"
depends on X86_SUMMIT && (!HIGHMEM64G || !ACPI)
next reply other threads:[~2006-06-24 0:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-24 0:19 Andi Kleen [this message]
2006-06-24 0:38 ` [PATCH] [20/82] i386: Panic the system when a NUMA kernel doesn't run on IBM NUMA Dave Jones
2006-06-24 0:42 ` Andi Kleen
2006-06-24 1:03 ` Keith Mannthey
2006-06-24 1:15 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=449C8510.mailCWD11E44E@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox