Re: 2.6.17-mm2

Andrew Morton
2006-06-28T19:11:26Z

On Wed, 28 Jun 2006 07:43:14 -0700
"Martin J. Bligh" <mbligh@google.com> wrote:

> Andrew Morton wrote:
> > On Wed, 28 Jun 2006 03:42:15 -0700
> > Andrew Morton <akpm@osdl.org> wrote:
> >
> >
> >>his is caused by the vsprintf() changes. Right now, if you do
> >>
> >> snprintf(buf, 4, "1111111111111");
> >>
> >>the memory at `buf' gets [31 31 31 31 00], which is not good.
> >>
> >>This'll plug it, but I didn't check very hard whether it still has any
> >>off-by-ones, or if breaks the intent of Jeremy's patch. I think it's OK..
>
> Aha, you're a genius!

That's not what my kids say.

> How the hell did you figure that one out?

Found a way to reproduce it - do `cat /proc/slabinfo > /dev/null' in a
tight loop. With that happening, a little two-way wasn't able to make
it through `dbench 4' without soiling the upholstery. Then bisection-searching.