Re: [RFC][PATCH] delay accounting taskstats interface send tgid once

Andrew Morton
2006-06-26T19:38:31Z

On Mon, 26 Jun 2006 12:04:16 -0700
Jay Lan <jlan@sgi.com> wrote:

> Is this patch supposed to go on top of all other patches? Or is it
> supposed to replace any? I had failure applying this patch on top
> of all previously applied.

It would have got tangled up with the task-watchers patches.

ahem. Documentation/SubmitChecklist, item 2:

In file included from kernel/exit.c:29:
include/linux/taskstats_kern.h: In function 'taskstats_exit_send':
include/linux/taskstats_kern.h:80: error: parameter name omitted
In file included from include/linux/delayacct.h:21,
from kernel/fork.c:47:
include/linux/taskstats_kern.h: In function 'taskstats_exit_send':
include/linux/taskstats_kern.h:80: error: parameter name omitted
make[1]: *** [kernel/exit.o] Error 1
make: *** [kernel/exit.o] Error 2
make: *** Waiting for unfinished jobs....
make[1]: *** [kernel/fork.o] Error 1
make: *** [kernel/fork.o] Error 2

diff -puN include/linux/taskstats_kern.h~delay-accounting-taskstats-interface-send-tgid-once-fixes include/linux/taskstats_kern.h
--- a/include/linux/taskstats_kern.h~delay-accounting-taskstats-interface-send-tgid-once-fixes
+++ a/include/linux/taskstats_kern.h
@@ -77,7 +77,8 @@ static inline void taskstats_exit_alloc(
static inline void taskstats_exit_free(struct taskstats *ptidstats)
{}
static inline void taskstats_exit_send(struct task_struct *tsk,
- struct taskstats *tidstats, int)
+ struct taskstats *tidstats,
+ int group_dead)
{}
static inline void taskstats_tgid_init(struct signal_struct *sig)
{}
_

http://www.zip.com.au/~akpm/linux/patches/stuff/x.bz2 contains the current
-mm rollup up to and including this patch. It's against 2.6.17.