public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Haren Myneni <haren@us.ibm.com>
To: vgoyal@in.ibm.com
Cc: Troy Benjegerdes <hozer@hozed.org>,
	Fastboot mailing list <fastboot@lists.osdl.org>,
	linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
	ellerman@au1.ibm.com, Michael Ellerman <michael@ellerman.id.au>
Subject: [PATCH] powerpc: build fix for ppc32 with CONFIG_KEXEC
Date: Mon, 26 Jun 2006 12:14:02 -0700	[thread overview]
Message-ID: <44A031FA.7050502@us.ibm.com> (raw)
In-Reply-To: <20060626135801.GC8985@in.ibm.com>

[-- Attachment #1: Type: text/plain, Size: 1269 bytes --]

Vivek Goyal wrote:

>On Mon, Jun 26, 2006 at 01:31:28AM -0500, Troy Benjegerdes wrote:
>  
>
>>various things like 'reserve_crashkernel' are referenced, but only
>>exist in arch/powerpc/kernel/machine_kexec_64.c.
>>
>>    
>>
>
>I think for ppc32 the framework is present for kexec/kdump but nobody 
>is actively testing/maintaining it as of today.
>  
>
At present, even though kexec support is included for PPC32, I believe, 
it has been actively tested/maintained only on gamecube.

Michael, if you are OK with this patch, please send it to upstream.
Thanks
Haren

arch/powerpc/kernel/built-in.o(.init.text+0x1c98): In function 
`early_init_devtree':
: undefined reference to `reserve_crashkernel'
arch/powerpc/kernel/built-in.o(.init.text+0x1d90): In function 
`early_init_devtree':
: undefined reference to `overlaps_crashkernel'
 This patch will fix the above build errors on ppc32 with CONFIG_KEXEC.  
Both reserve_crashkernel() and overlaps_crashkernel() should be moved to 
machine_kexec.c() after the kdump support is included on ppc32.

Signed-off-by: Haren Myneni <haren@us.ibm.com>





>Thanks
>Vivek
>_______________________________________________
>fastboot mailing list
>fastboot@lists.osdl.org
>https://lists.osdl.org/mailman/listinfo/fastboot
>  
>


[-- Attachment #2: ppc32-kexec-build-fix.patch --]
[-- Type: text/x-patch, Size: 527 bytes --]

--- linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c.orig	2006-06-26 05:33:51.000000000 -0700
+++ linux-2.6.17-git10/arch/powerpc/kernel/machine_kexec_32.c	2006-06-26 05:47:04.000000000 -0700
@@ -63,3 +63,16 @@ int default_machine_kexec_prepare(struct
 {
 	return 0;
 }
+
+/*
+ * FIXME: Move the following functions to machine_kexec.c after
+ * kdump support is included on ppc32.
+ */
+void __init reserve_crashkernel(void)
+{
+}
+
+int overlaps_crashkernel(unsigned long start, unsigned long size)
+{
+	return 0;
+}

  parent reply	other threads:[~2006-06-26 19:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26  6:31 ppc32 with CONFIG_KEXEC broken Troy Benjegerdes
2006-06-26 13:58 ` Vivek Goyal
2006-06-26 17:01   ` Troy Benjegerdes
2006-06-26 19:14   ` Haren Myneni [this message]
2006-06-26 17:01 ` Josh Boyer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A031FA.7050502@us.ibm.com \
    --to=haren@us.ibm.com \
    --cc=ellerman@au1.ibm.com \
    --cc=fastboot@lists.osdl.org \
    --cc=hozer@hozed.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=michael@ellerman.id.au \
    --cc=vgoyal@in.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox