From: Shailabh Nagar <nagar@watson.ibm.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Balbir Singh <balbir@in.ibm.com>, Jay Lan <jlan@engr.sgi.com>,
Chris Sturtivant <csturtiv@sgi.com>,
linux-kernel <linux-kernel@vger.kernel.org>
Subject: [RFC][PATCH] per-task delay accounting: avoid send without listeners
Date: Mon, 26 Jun 2006 18:27:27 -0400 [thread overview]
Message-ID: <44A05F4F.8060503@watson.ibm.com> (raw)
Don't send taskstats (per-pid or per-tgid) on thread exit when no one is
listening for such data.
Currently the taskstats interface allocates a structure, fills it in
and calls netlink to send out per-pid and per-tgid stats regardless of whether
a userspace listener for the data exists (netlink layer would check for that
and avoid the multicast).
As a result of this patch, the check for the no-listener case is performed
early, avoiding the redundant allocation and filling up of the taskstats
structures.
Signed-off-by: Balbir Singh <balbir@in.ibm.com>
Signed-off-by: Shailabh Nagar <nagar@watson.ibm.com>
---
include/linux/taskstats_kern.h | 13 ++++++++++++-
1 files changed, 12 insertions(+), 1 deletion(-)
Index: linux-2.6.17/include/linux/taskstats_kern.h
===================================================================
--- linux-2.6.17.orig/include/linux/taskstats_kern.h 2006-06-26 16:45:33.000000000 -0400
+++ linux-2.6.17/include/linux/taskstats_kern.h 2006-06-26 16:47:08.000000000 -0400
@@ -9,6 +9,7 @@
#include <linux/taskstats.h>
#include <linux/sched.h>
+#include <net/genetlink.h>
enum {
TASKSTATS_MSG_UNICAST, /* send data only to requester */
@@ -19,9 +20,19 @@ enum {
extern kmem_cache_t *taskstats_cache;
extern struct mutex taskstats_exit_mutex;
+static inline int taskstats_has_listeners(void)
+{
+ if (!genl_sock)
+ return 0;
+ return netlink_has_listeners(genl_sock, TASKSTATS_LISTEN_GROUP);
+}
+
+
static inline void taskstats_exit_alloc(struct taskstats **ptidstats)
{
- *ptidstats = kmem_cache_zalloc(taskstats_cache, SLAB_KERNEL);
+ *ptidstats = NULL;
+ if (taskstats_has_listeners())
+ *ptidstats = kmem_cache_zalloc(taskstats_cache, SLAB_KERNEL);
}
static inline void taskstats_exit_free(struct taskstats *tidstats)
next reply other threads:[~2006-06-26 22:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 22:27 Shailabh Nagar [this message]
2006-06-26 22:33 ` [RFC][PATCH] per-task delay accounting: avoid send without listeners Shailabh Nagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A05F4F.8060503@watson.ibm.com \
--to=nagar@watson.ibm.com \
--cc=akpm@osdl.org \
--cc=balbir@in.ibm.com \
--cc=csturtiv@sgi.com \
--cc=jlan@engr.sgi.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox