Re: [PATCH] imacfb: Add Intel-based Macintosh Framebuffer Support

[Edgar Hucek <hostmaster@ed-soft.at>]

At the moment i work on implementing Machine detection through DMI
and make the driver loadable as module. I know that the driver is
not perfekt, but a good starting point :)

cu

Edgar (gimli) Hucek

Dave Jones schrieb:
> On Mon, Jun 26, 2006 at 06:03:02PM +0000, Linux Kernel wrote:
>  > commit 90b4f9aca4d124d114e02bbb3d1d4f3d1d47138f
>  > tree e367b2fd3ad08b706bd7825c6251a95284f3bb76
>  > parent 1a8c9795290361cef232fd54f425a57d143108a8
>  > author Edgar Hucek <hostmaster@ed-soft.at> Mon, 26 Jun 2006 14:26:59 -0700
>  > committer Linus Torvalds <torvalds@g5.osdl.org> Mon, 26 Jun 2006 23:58:32 -0700
>  > 
>  > [PATCH] imacfb: Add Intel-based Macintosh Framebuffer Support
>  > 
>  > This patch adds a new framebuffer driver for the Intel Based macs.  This
>  > framebuffer is needed when booting from EFI to get something out the box.
>  > 
>  > [akpm: note: doesn't support modular building]
> 
> This scares me from a distro kernel point of view too, because
> it does no probing that it's actually running on a mac, (be that
> through DMI strings or PCI idents).  Instead if it hasn't been 
> passed a boot option, it sets model to 'M_NEW'....
> 
>  > +	case M_NEW:
>  > +	case M_I20:
>  > +		screen_info.lfb_width = 1680;
>  > +		screen_info.lfb_height = 1050;
>  > +		screen_info.lfb_linelength = 1728 * 4;
>  > +		screen_info.lfb_base = 0x80010000;
>  > +		break;
> 
> And then assumes it can scribble at 0x80010000.
> 
> Whilst in most cases the request_region that follows is going to fail,
> the possibility exists that something entirely different could be
> mapped there, guaranteeing fun times should Apple ever do something
> silly like, mapping the NVRAM there..
> 
> 		Dave
>