public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "H. Peter Anvin" <hpa@zytor.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: klibc@zytor.com, linux-kernel@vger.kernel.org
Subject: Re: [klibc] [klibc 28/43] mips support for klibc
Date: Tue, 27 Jun 2006 08:32:11 -0700	[thread overview]
Message-ID: <44A14F7B.2040600@zytor.com> (raw)
In-Reply-To: <20060626230345.GA14345@linux-mips.org>

Ralf Baechle wrote:
> On Sun, Jun 25, 2006 at 05:58:05PM -0700, H. Peter Anvin wrote:
> 
>> +typedef struct flock {
>> +	short	l_type;
>> +	short	l_whence;
>> +	loff_t	l_start;
>> +	loff_t	l_len;
>> +	pid_t	l_pid;
>> +} flock_t;
> 
> 32-bit MIPS uses this:
> 
> struct flock {
>         short   l_type;
>         short   l_whence;
>         off_t   l_start;
>         off_t   l_len;
>         long    l_sysid;
>         __kernel_pid_t l_pid;
>         long    pad[4];
> };

Does it use that for F_GETLK64 and friends?  klibc overrides the 
definitions so that F_GETLK is really F_GETLK64 etc; thus, "struct 
flock" in klibc userspace is really "struct flock64".  (To put it 
differently, klibc is always large-file compliant.)

As far as I can tell, MIPS uses the generic definition for struct 
flock64, which is the one I have above, so it should be correct.

	-hpa

      reply	other threads:[~2006-06-27 15:32 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26  0:58 [klibc 28/43] mips support for klibc H. Peter Anvin
2006-06-26 23:03 ` Ralf Baechle
2006-06-27 15:32   ` H. Peter Anvin [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A14F7B.2040600@zytor.com \
    --to=hpa@zytor.com \
    --cc=klibc@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ralf@linux-mips.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox