Re: [RFC] [patch 2/6] [Network namespace] Network device sharing by view

Andrew Morton
2006-06-11T10:19:22Z

On Fri, 09 Jun 2006 23:02:04 +0200
dlezcano@fr.ibm.com wrote:

> +int net_ns_dev_add(const char *devname,
> + struct net_ns_dev_list *devlist)
> +{
> + struct net_ns_dev *db;
> + struct net_device *dev;
> + int ret = 0;
> +
> + read_lock(&dev_base_lock);
> +
> + for (dev = dev_base; dev; dev = dev->next)
> + if (!strncmp(dev->name, devname, IFNAMSIZ))
> + break;
> +
> + if (!dev) {
> + ret = -ENODEV;
> + goto out;
> + }
> +
> + db = kmalloc(sizeof(*db), GFP_KERNEL);

sleep-in-spinlock. Please always test new code with all kernel debugging
options enabled.