From: Jes Sorensen <jes@sgi.com>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org,
David Brownell <david-b@pacbell.net>
Subject: Re: [patch] fix static linking of NFS
Date: Tue, 27 Jun 2006 21:01:51 +0200 [thread overview]
Message-ID: <44A1809F.5030306@sgi.com> (raw)
In-Reply-To: <1151426697.23773.10.camel@lade.trondhjem.org>
Trond Myklebust wrote:
> On Tue, 2006-06-27 at 12:33 -0400, Trond Myklebust wrote:
>>> Remove __exit declarations from functions called from __init code to
>>> avoid link errors when the __exit section is discarded, eg NFS is
>>> linked statically into the kernel.
>>>
>>> Signed-off-by: Jes Sorensen <jes@sgi.com>
>> Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>
>
> Oops... I was a bit too quick there. Could you clean up the forward
> declarations in "internal.h" too, please.
>
> Cheers,
> Trond
Good point, I didn't notice those because the compiler didn't moan. I'll
look into doing another patch, but it might not be until Thursday.
Cheers,
Jes
next prev parent reply other threads:[~2006-06-27 19:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 9:29 [patch] fix static linking of NFS Jes Sorensen
2006-06-27 16:33 ` Trond Myklebust
2006-06-27 16:44 ` Trond Myklebust
2006-06-27 19:01 ` Jes Sorensen [this message]
2006-06-27 19:21 ` David Brownell
2006-06-27 19:59 ` David Brownell
2006-06-27 20:08 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44A1809F.5030306@sgi.com \
--to=jes@sgi.com \
--cc=akpm@osdl.org \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox