From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161254AbWF0TBe (ORCPT ); Tue, 27 Jun 2006 15:01:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1161255AbWF0TBe (ORCPT ); Tue, 27 Jun 2006 15:01:34 -0400 Received: from omx1-ext.sgi.com ([192.48.179.11]:7370 "EHLO omx1.americas.sgi.com") by vger.kernel.org with ESMTP id S1161254AbWF0TBd (ORCPT ); Tue, 27 Jun 2006 15:01:33 -0400 Message-ID: <44A1809F.5030306@sgi.com> Date: Tue, 27 Jun 2006 21:01:51 +0200 From: Jes Sorensen User-Agent: Thunderbird 1.5.0.4 (X11/20060614) MIME-Version: 1.0 To: Trond Myklebust CC: Linus Torvalds , Andrew Morton , linux-kernel@vger.kernel.org, David Brownell Subject: Re: [patch] fix static linking of NFS References: <1151426029.23773.7.camel@lade.trondhjem.org> <1151426697.23773.10.camel@lade.trondhjem.org> In-Reply-To: <1151426697.23773.10.camel@lade.trondhjem.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Trond Myklebust wrote: > On Tue, 2006-06-27 at 12:33 -0400, Trond Myklebust wrote: >>> Remove __exit declarations from functions called from __init code to >>> avoid link errors when the __exit section is discarded, eg NFS is >>> linked statically into the kernel. >>> >>> Signed-off-by: Jes Sorensen >> Acked-by: Trond Myklebust > > Oops... I was a bit too quick there. Could you clean up the forward > declarations in "internal.h" too, please. > > Cheers, > Trond Good point, I didn't notice those because the compiler didn't moan. I'll look into doing another patch, but it might not be until Thursday. Cheers, Jes