public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jeff@garzik.org>
To: Linus Torvalds <torvalds@osdl.org>
Cc: Marcel Holtmann <marcel@holtmann.org>, Greg KH <greg@kroah.com>,
	Dmitry Torokhov <dtor_core@ameritech.net>,
	Andrew Morton <akpm@osdl.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git pull] Input update for 2.6.17
Date: Wed, 28 Jun 2006 19:40:49 -0400	[thread overview]
Message-ID: <44A31381.8090101@garzik.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0606281502280.12404@g5.osdl.org>

Linus Torvalds wrote:
> 
> On Wed, 28 Jun 2006, Jeff Garzik wrote:
> 
>> Linus Torvalds wrote:
>>> Anyway, "urb->transfer_buffer" was initialized with
>>>
>>> 	urb->transfer_buffer = skb->data;
>>>
>>> and I'm pretty damn sure you're supposed to just kfree() it.
>> eh?  I would think dev_kfree_skb(), because who knows whether the skb was
>> cloned, split, data buffer adjusted, destructors need to be called...
> 
> Well, we don't actually have the skb available any more.

You do:

>         urb->transfer_buffer = skb->data;
>         urb->transfer_buffer_length = skb->len;
> 
>         __fill_isoc_desc(urb, skb->len, le16_to_cpu(husb->isoc_out_ep->desc.wMaxPacketSize));
> 
>         _urb->priv = skb;

so it looks like you can grab it out of the 'priv' field.

And a damned good thing too...

	Jeff



  parent reply	other threads:[~2006-06-28 23:41 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26  6:35 [git pull] Input update for 2.6.17 Dmitry Torokhov
2006-06-27  6:13 ` Linus Torvalds
2006-06-27  6:37   ` Greg KH
2006-06-27 18:36     ` Linus Torvalds
2006-06-27 19:16       ` Linus Torvalds
2006-06-27 19:35         ` Linus Torvalds
2006-06-27 19:40           ` Dmitry Torokhov
2006-06-27 21:03             ` Linus Torvalds
2006-06-27 19:46           ` Marcel Holtmann
2006-06-28  4:07             ` Linus Torvalds
2006-06-28  4:36               ` Linus Torvalds
2006-06-28  7:03                 ` Jeff Garzik
2006-06-28 22:05                   ` Linus Torvalds
2006-06-28 23:03                     ` Marcel Holtmann
2006-06-28 23:40                     ` Jeff Garzik [this message]
2006-06-28 23:55                       ` Linus Torvalds
2006-06-27 19:33       ` Marcel Holtmann
2006-06-27 12:30   ` Dmitry Torokhov
  -- strict thread matches above, loose matches on Subject: below --
2006-06-28  3:50 Dmitry Torokhov
2006-04-02  5:56 Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A31381.8090101@garzik.org \
    --to=jeff@garzik.org \
    --cc=akpm@osdl.org \
    --cc=dtor_core@ameritech.net \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox