From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751779AbWF1XlF (ORCPT ); Wed, 28 Jun 2006 19:41:05 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751782AbWF1XlF (ORCPT ); Wed, 28 Jun 2006 19:41:05 -0400 Received: from srv5.dvmed.net ([207.36.208.214]:55770 "EHLO mail.dvmed.net") by vger.kernel.org with ESMTP id S1751779AbWF1XlC (ORCPT ); Wed, 28 Jun 2006 19:41:02 -0400 Message-ID: <44A31381.8090101@garzik.org> Date: Wed, 28 Jun 2006 19:40:49 -0400 From: Jeff Garzik User-Agent: Thunderbird 1.5.0.4 (X11/20060614) MIME-Version: 1.0 To: Linus Torvalds CC: Marcel Holtmann , Greg KH , Dmitry Torokhov , Andrew Morton , LKML Subject: Re: [git pull] Input update for 2.6.17 References: <200606260235.03718.dtor_core@ameritech.net> <20060627063734.GA28135@kroah.com> <1151437593.25011.38.camel@localhost> <44A229C0.5060702@garzik.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -4.2 (----) X-Spam-Report: SpamAssassin version 3.1.3 on srv5.dvmed.net summary: Content analysis details: (-4.2 points, 5.0 required) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Linus Torvalds wrote: > > On Wed, 28 Jun 2006, Jeff Garzik wrote: > >> Linus Torvalds wrote: >>> Anyway, "urb->transfer_buffer" was initialized with >>> >>> urb->transfer_buffer = skb->data; >>> >>> and I'm pretty damn sure you're supposed to just kfree() it. >> eh? I would think dev_kfree_skb(), because who knows whether the skb was >> cloned, split, data buffer adjusted, destructors need to be called... > > Well, we don't actually have the skb available any more. You do: > urb->transfer_buffer = skb->data; > urb->transfer_buffer_length = skb->len; > > __fill_isoc_desc(urb, skb->len, le16_to_cpu(husb->isoc_out_ep->desc.wMaxPacketSize)); > > _urb->priv = skb; so it looks like you can grab it out of the 'priv' field. And a damned good thing too... Jeff