public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: KaiGai Kohei <kaigai@ak.jp.nec.com>
To: David Woodhouse <dwmw2@infradead.org>
Cc: Adrian Bunk <bunk@stusta.de>,
	jffs-dev@axis.com, linux-kernel@vger.kernel.org
Subject: Re: unused fs/jffs2/acl.c:jffs2_clear_acl()
Date: Thu, 29 Jun 2006 23:27:32 +0900	[thread overview]
Message-ID: <44A3E354.6050001@ak.jp.nec.com> (raw)
In-Reply-To: <1151586970.16413.16.camel@pmac.infradead.org>

David Woodhouse wrote:
> On Thu, 2006-06-29 at 15:01 +0200, Adrian Bunk wrote:
> 
>>it might not have been intended that jffs2_clear_acl() in Linus' tree
>>is unused?
> 
> 
> I suspect you're right -- thanks for pointing it out.
> 
> Kaigai-san?

I'm sorry, it's a serious BUG.
When an inode is cleared, jffs2_clear_acl() should be called
to release on-memory ACL. Because the current implementation
didn't care about this cleaning-up, we have memory-leaking.

Please wait a patch for a while.

Thanks,
-- 
KaiGai Kohei <kaigai@kaigai.gr.jp>

  reply	other threads:[~2006-06-29 14:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-29 13:01 unused fs/jffs2/acl.c:jffs2_clear_acl() Adrian Bunk
2006-06-29 13:16 ` David Woodhouse
2006-06-29 14:27   ` KaiGai Kohei [this message]
2006-07-02 14:08     ` KaiGai Kohei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A3E354.6050001@ak.jp.nec.com \
    --to=kaigai@ak.jp.nec.com \
    --cc=bunk@stusta.de \
    --cc=dwmw2@infradead.org \
    --cc=jffs-dev@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox