2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

[Gregoire Favre]

Hello,

just tried to compil 2.6.17-mm4 under amd64 and it fails with :

  AR      arch/x86_64/lib/lib.a
  GEN     .version
  CHK     include/linux/compile.h
  UPD     include/linux/compile.h
  CC      init/version.o
  LD      init/built-in.o
  LD      .tmp_vmlinux1
arch/x86_64/kernel/built-in.o: In function `module_arch_cleanup':
(.text.module_arch_cleanup+0x1): undefined reference to `alternatives_smp_module_del'
arch/x86_64/kernel/built-in.o: In function `module_finalize':
(.text.module_finalize+0xe8): undefined reference to `alternatives_smp_module_add'
make: *** [.tmp_vmlinux1] Error 1


Please CC to me if some more info are needed as I am not on this list.
-- 
Grégoire FAVRE  http://gregoire.favre.googlepages.com  http://www.gnupg.org

Re: 2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

[Andrew Morton]

Gregoire Favre <gregoire.favre@gmail.com> wrote:
>
> Hello,
> 
> just tried to compil 2.6.17-mm4 under amd64 and it fails with :
> 
>   AR      arch/x86_64/lib/lib.a
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/x86_64/kernel/built-in.o: In function `module_arch_cleanup':
> (.text.module_arch_cleanup+0x1): undefined reference to `alternatives_smp_module_del'
> arch/x86_64/kernel/built-in.o: In function `module_finalize':
> (.text.module_finalize+0xe8): undefined reference to `alternatives_smp_module_add'
> make: *** [.tmp_vmlinux1] Error 1
> 
> 

Thanks.  Reverting
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm4/broken-out/x86-dont-print-out-smp-info-on-up-kernels.patch
will fix it.

<looks at davej>

That patch is pretty yuk anyway

 void module_arch_cleanup(struct module *mod)
 {
+#ifdef CONFIG_SMP
	alternatives_smp_module_del(mod);
+#endif
 }

Should be a stub in a header file, which would fix this problem too.

Re: 2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

[Rene Herman]

Andrew Morton wrote:

> <looks at davej>
> 
> That patch is pretty yuk anyway
> 
>  void module_arch_cleanup(struct module *mod)
>  {
> +#ifdef CONFIG_SMP
> 	alternatives_smp_module_del(mod);
> +#endif
>  }
> 
> Should be a stub in a header file, which would fix this problem too.

Gerd Hoffmann already did this and I suppose it's in some upstream tree 
somewhere:

http://marc.theaimsgroup.com/?l=linux-kernel&m=114743413932319&w=2

Rene.

Re: 2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

[Andrew Morton]

Rene Herman <rene.herman@keyaccess.nl> wrote:
>
> Andrew Morton wrote:
> 
> > <looks at davej>
> > 
> > That patch is pretty yuk anyway
> > 
> >  void module_arch_cleanup(struct module *mod)
> >  {
> > +#ifdef CONFIG_SMP
> > 	alternatives_smp_module_del(mod);
> > +#endif
> >  }
> > 
> > Should be a stub in a header file, which would fix this problem too.
> 
> Gerd Hoffmann already did this and I suppose it's in some upstream tree 
> somewhere:

I'd say it got lost.

> http://marc.theaimsgroup.com/?l=linux-kernel&m=114743413932319&w=2
> 

<snarf>

Thanks.

Re: 2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

[Dave Jones]

On Thu, Jun 29, 2006 at 04:40:54PM -0700, Andrew Morton wrote:

 > > > Should be a stub in a header file, which would fix this problem too.
 > > 
 > > Gerd Hoffmann already did this and I suppose it's in some upstream tree 
 > > somewhere:
 > I'd say it got lost.
 > 
 > > http://marc.theaimsgroup.com/?l=linux-kernel&m=114743413932319&w=2

Ha, I was just reconstructing the exact same patch.

 > <snarf>

Yay!

		Dave


-- 
http://www.codemonkey.org.uk