public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Kirill Korotaev <dev@openvz.org>
To: Andrew Morton <akpm@osdl.org>, Chris Wright <chrisw@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	marcelo.tosatti@cyclades.com, devel@openvz.org,
	"Vasily Averin" <vvs@sw.ru>, "Andrey Savochkin" <saw@sawoct.com>,
	Monakhov Dmintiy <dmonakhov@sw.ru>
Subject: [PATCH] EXT3: ext3 block bitmap leakage
Date: Fri, 30 Jun 2006 13:41:05 +0400	[thread overview]
Message-ID: <44A4F1B1.1060406@openvz.org> (raw)

Andrew, Chris,

this bug is not relevant for 2.6.17 and later.
However, it is relevant for all 2.4.x and <2.6.17 kernels,
so I think this can be of interest to some people and worth commiting to 
2.6.16.x



This patch fixes ext3 block bitmap leakage,
which leads to the following fsck messages on
_healthy_ filesystem:
Block bitmap differences:  -64159 -73707

All kernels up to 2.6.17 have this bug.

Found by
   Vasily Averin <vvs@sw.ru> and Andrey Savochkin <saw@sawoct.com>
Test case triggered the issue was created by
   Dmitry Monakhov <dmonakhov@sw.ru>

Signed-Off-By: Vasiliy Averin <vvs@sw.ru>
Signed-Off-By: Andrey Savochkin <saw@sawoct.com>
Signed-Off-By: Kirill Korotaev <dev@openvz.org>
CC: Dmitry Monakhov <dmonakhov@sw.ru>

--- ./fs/ext3/inode.c.e3crp	2006-06-28 05:22:40.000000000 +0400
+++ ./fs/ext3/inode.c	2006-06-27 13:31:20.000000000 +0400
@@ -585,6 +585,7 @@ static int ext3_alloc_branch(handle_t *h

  	branch[0].key = cpu_to_le32(parent);
  	if (parent) {
+		keys = 1;
  		for (n = 1; n < num; n++) {
  			struct buffer_head *bh;
  			/* Allocate the next block */


                 reply	other threads:[~2006-06-30  9:41 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=44A4F1B1.1060406@openvz.org \
    --to=dev@openvz.org \
    --cc=akpm@osdl.org \
    --cc=chrisw@osdl.org \
    --cc=devel@openvz.org \
    --cc=dmonakhov@sw.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=saw@sawoct.com \
    --cc=vvs@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox