Re: [Patch][RFC] Disabling per-tgid stats on task exit in taskstats

Jay Lan
2006-06-09T23:47:36Z

Andrew Morton wrote:
>Jay Lan <jlan@engr.sgi.com> wrote:
>
>>If you can show me how to not sending per-tgid with current patchset,
>>i would be very happy to drop this request.
>>
>
>pleeeze, not a global sysctl. It should be some per-client subscription thing.
>

Per-client subscription is not possible since it is the push (multicast)
model we
talk about and delayacct needs tgid.

>But the overhead at present is awfully low. If we don't need this ability
>at present (and I don't think we do) then a paper design would be
>sufficient at this time. As long as we know we can do this in the future
>without breaking existing APIs then OK.
>
i can see if an exiting process is the only process in the thread group,
the (not is_thread_group) condition would be true. So, that leaves
multi-threaded applications that are not interested in tgid-data still
receive 2x taskstats data.

Is a system-wide switch that bad? A site that needs tgid stats can live
with the performance consequence while those do not need tgid can
enjoy a pure per-task stats data. (I would argue that a thread group
is some sort of task aggregate.)

How about sending tgid stats when the last process in the group exist?
But do not send it if not the last in the thread?

Thanks,
- jay